Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit testing #41

Open
elezar opened this issue Nov 30, 2023 · 11 comments · Fixed by #70
Open

Add unit testing #41

elezar opened this issue Nov 30, 2023 · 11 comments · Fixed by #70
Assignees
Labels
lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.

Comments

@elezar
Copy link
Contributor

elezar commented Nov 30, 2023

We should start adding basic unit tests and include a GitHub action that runs these.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 29, 2024
@pohly
Copy link
Contributor

pohly commented Apr 15, 2024

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 15, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 13, 2024
@pohly
Copy link
Contributor

pohly commented Aug 19, 2024

/remove-lifecycle rotten
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 19, 2024
@johnbelamaric johnbelamaric moved this from 🆕 New to 🔖 Ready in SIG Node: Dynamic Resource Allocation Dec 10, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented Dec 10, 2024

I can take this one!

/assign

@nojnhuh
Copy link
Contributor

nojnhuh commented Dec 10, 2024

/lifecycle active

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Dec 10, 2024
@nojnhuh nojnhuh moved this from 🔖 Ready to 🏗 In progress in SIG Node: Dynamic Resource Allocation Dec 10, 2024
@nojnhuh nojnhuh mentioned this issue Dec 10, 2024
@nojnhuh nojnhuh moved this from 🏗 In progress to 👀 In review in SIG Node: Dynamic Resource Allocation Dec 10, 2024
@pohly pohly moved this from 👀 In review to 🏗 In progress in SIG Node: Dynamic Resource Allocation Dec 12, 2024
@pohly pohly moved this from 🏗 In progress to 🔖 Ready in SIG Node: Dynamic Resource Allocation Dec 12, 2024
@nojnhuh nojnhuh moved this from 🔖 Ready to 🏗 In progress in SIG Node: Dynamic Resource Allocation Jan 13, 2025
@nojnhuh nojnhuh moved this from 🏗 In progress to 🔖 Ready in SIG Node: Dynamic Resource Allocation Jan 13, 2025
@elezar
Copy link
Contributor Author

elezar commented Jan 18, 2025

@nojnhuh let's reopen this since #70 doesn't completely resolve this.

Alternatively, do you have thoughts on tracking additional tests?

@nojnhuh
Copy link
Contributor

nojnhuh commented Jan 18, 2025

The button is gray for me but I'll try the bot:

/reopen

The rest of the driver that interfaces more with kubelet and CDI didn't seem particularly unit-testable, and I'm not totally convinced unit tests are super valuable there (at least right now) if the e2e tests cover the important parts. Is there specific functionality you'd like to see validated in unit tests?

@k8s-ci-robot k8s-ci-robot reopened this Jan 18, 2025
@k8s-ci-robot
Copy link
Contributor

@nojnhuh: Reopened this issue.

In response to this:

The button is gray for me but I'll try the bot:

/reopen

The rest of the driver that interfaces more with kubelet and CDI didn't seem particularly unit-testable, and I'm not totally convinced unit tests are super valuable there (at least right now) if the e2e tests cover the important parts. Is there specific functionality you'd like to see validated in unit tests?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants