Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting sidecar containers during Pod termination #4438

Open
1 of 4 tasks
matthyx opened this issue Jan 25, 2024 · 56 comments
Open
1 of 4 tasks

Restarting sidecar containers during Pod termination #4438

matthyx opened this issue Jan 25, 2024 · 56 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@matthyx
Copy link
Contributor

matthyx commented Jan 25, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 25, 2024
@matthyx
Copy link
Contributor Author

matthyx commented Jan 25, 2024

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 25, 2024
@SergeyKanzhelev
Copy link
Member

/stage alpha
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 27, 2024
@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 27, 2024
@mrunalp
Copy link
Contributor

mrunalp commented Feb 2, 2024

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2024
@AnaMMedina21
Copy link
Member

Hello @matthyx 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@AnaMMedina21 AnaMMedina21 moved this to Tracked for Enhancements Freeze in 1.30 Enhancements Tracking Feb 7, 2024
@Checksumz
Copy link

Hi @matthyx ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@matthyx
Copy link
Contributor Author

matthyx commented Feb 15, 2024

Hi @matthyx ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

kubernetes/website#45142

@Vyom-Yadav
Copy link
Member

Hello @matthyx 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!


Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

A feature gate is being added, so we'll need docs, marking it as Need Docs. Thanks!

@AnaMMedina21
Copy link
Member

Hey again @matthyx 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP, I didn't see any in the description
As always, we are here to help if any questions come up. Thanks!

@AnaMMedina21 AnaMMedina21 moved this from Tracked for Enhancements Freeze to Tracked for Code Freeze in 1.30 Enhancements Tracking Feb 29, 2024
@matthyx
Copy link
Contributor Author

matthyx commented Mar 1, 2024

@AnaMMedina21 this is the main PR kubernetes/kubernetes#121412 however I'm not sure it will be finished on time...
I will keep you posted here!
/cc @gjkim42

@matthyx
Copy link
Contributor Author

matthyx commented Mar 6, 2024

@AnaMMedina21 we have missed code freeze, let's try again for 1.31

@Vyom-Yadav Vyom-Yadav moved this from Tracked for Code Freeze to Removed from Milestone in 1.30 Enhancements Tracking Mar 11, 2024
@Vyom-Yadav
Copy link
Member

@AnaMMedina21 I updated the status to Removed From Milestone

@pacoxu
Copy link
Member

pacoxu commented Mar 26, 2024

/milestone clear

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 13, 2025
@dipesh-rawat dipesh-rawat removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 13, 2025
@haircommander haircommander moved this from Triage to Proposed for consideration in SIG Node 1.33 KEPs planning Jan 28, 2025
@haircommander
Copy link
Contributor

/label lead-opted-in
/milestone v1.33

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 30, 2025
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 30, 2025
@bianbbc87
Copy link

bianbbc87 commented Feb 4, 2025

Hello @matthyx 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as Tracked for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@bianbbc87 bianbbc87 moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Feb 4, 2025
@matthyx
Copy link
Contributor Author

matthyx commented Feb 4, 2025

@bianbbc87 can you check the kep.yaml file, I think the latest commit changed the milestone to 1.33 and the status is implementable.

@bianbbc87
Copy link

@matthyx

Hi !
I've checked the changes.
It would be nice if you could add the two PRs below to the Alpha KEP checkbox.
#4890 #5098

Also, please change this to 1.33

  • Alpha release target (x.y): 1.32 -> 1.33

Thank you !

@bianbbc87 bianbbc87 moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.33 Enhancements Tracking Feb 5, 2025
@bianbbc87 bianbbc87 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 5, 2025
@ffromani
Copy link
Contributor

ffromani commented Feb 5, 2025

@matthyx howdy! thanks for the updates. Would you mind add a tracking section in the first message to track the items needed for beta graduation, much like you already have for alpha?
[EDIT] assuming we want to move to beta, it seems we are staying in alpha for 1.33? [/EDIT]

no need we stay in alpha for 1.33 (https://github.com/kubernetes/enhancements/pull/5098/files) sorry for the noise!

@pacoxu pacoxu moved this from Proposed for consideration to Tracked in SIG Node 1.33 KEPs planning Feb 8, 2025
@michellengnx
Copy link

Hello @matthyx 👋, v1.33 Docs Shadow here.
Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?
If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@matthyx
Copy link
Contributor Author

matthyx commented Feb 24, 2025

@michellengnx does it work if I repurpose kubernetes/website#45170 ?

@rytswd
Copy link
Member

rytswd commented Mar 1, 2025

Hi @matthyx 👋 -- this is Ryota (@rytswd) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@sn3hay
Copy link

sn3hay commented Mar 3, 2025

Hi @matthyx 👋, this is Sneha, from the 1.33 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 5th March, 2025. To opt in, please let us know and open a Feature Blog placeholder PR against [k/website](https://github.com/kubernetes/website) by the deadline. If you have any questions, please feel free to reach out to us!

Tip

Some timeline to keep in mind:

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@bianbbc87
Copy link

bianbbc87 commented Mar 4, 2025

Hey again @matthyx 👋, v1.33 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

The status of this enhancement is marked as At risk for code freeze.

As always, we are here to help if any questions come up. Thanks!

@bianbbc87 bianbbc87 moved this from Tracked for enhancements freeze to At risk for code freeze in 1.33 Enhancements Tracking Mar 4, 2025
@dipesh-rawat
Copy link
Member

Hi @matthyx 👋, v1.33 Enhancements team here,

Just a quick friendly reminder as we approach the code freeze later this week, at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

The current status of this enhancement is marked as At risk for code freeze. There are a few requirements mentioned in the comment #4438 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat
Copy link
Member

Hello @matthyx 👋, v1.33 Enhancements team here,

Unfortunately, the implementation (code-related) PRs associated with this enhancement are not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.33 milestone.

If you still wish to progress this enhancement in v1.33, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.33 milestone Mar 21, 2025
@dipesh-rawat dipesh-rawat moved this from At risk for code freeze to Removed from Milestone in 1.33 Enhancements Tracking Mar 21, 2025
@haircommander haircommander moved this from Tracked to Removed in SIG Node 1.33 KEPs planning Mar 24, 2025
@dipesh-rawat dipesh-rawat removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Removed from Milestone
Status: Removed from Milestone
Status: Removed
Status: Removed from Milestone
Status: Removed from Milestone
Status: Removed
Development

No branches or pull requests