Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: prow validation of image yaml #4941

Closed
strongjz opened this issue Mar 14, 2023 · 8 comments
Closed

BUG: prow validation of image yaml #4941

strongjz opened this issue Mar 14, 2023 · 8 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@strongjz
Copy link
Member

I was able to get an incorrect yaml merged into main. The ingress-nginx web cert sha was missing a char and an " but prow bot merged the PR.

File in question
https://github.com/kubernetes/k8s.io/pull/4929/files#diff-177c8d0b37aa1ffb1cdbadfd7455d4922786090c8053452caa1da8a30da74f97R216

The verify job that I think should have failed? https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/k8s.io/4929/pull-k8sio-verify/1635604760147005440
@strongjz strongjz added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Mar 14, 2023
@strongjz
Copy link
Member Author

another image was a copy paste error missing one char on the sha https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/images/k8s-staging-ingress-nginx/images.yaml#L203

@TerryHowe
Copy link
Member

Is this a bug or a feature request?

Is the expectation just to validate the sha?

@BenTheElder
Copy link
Member

xref: kubernetes-sigs/promo-tools#633

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 14, 2023
@BenTheElder
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 14, 2023
@BenTheElder
Copy link
Member

/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jun 14, 2023
@T-Lakshmi
Copy link

/kind bug

" is missing here.

"sha256:01d181618f270f2a96c04006f33b2699ad3ccb02da48d0f89b22abce084b292": [v20230312-helm-chart-4.5.2-28-g66a760794"]

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 9, 2024
@BenTheElder
Copy link
Member

see also: #5221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@TerryHowe @BenTheElder @strongjz @k8s-ci-robot @k8s-triage-robot @T-Lakshmi