-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review kubeadm package layout #1205
Comments
Do it have a decision ? |
It is a similar issue about test utilites. #1257 |
Not yet.
Similar, but not overlapping |
Got it. kubernetes/kubernetes#71702, which fixes for #1257, will be hold and wait for v1.14 planning. |
@fabriziopandini I would like to help on this. We might split this issue in small actionables issues. If you want we can talk about it in irc or here as you wish. |
@luxas considering that this cycle seems there are people willing to help, it will be great to hear what do you think about this idea... Cleaning up some tech debt and getting in better shape for enabling kubeadm vendoring in future are the main reason behind this. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-help because it isn't clear from the comments here if there is consensus or exactly what that consensus is. |
/close |
@fabriziopandini: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
as per comment kubernetes/kubernetes#70346 (comment) and kubernetes/kubernetes#70333 (comment)
If there is consensus, kubeadm package layout should be aligned with other Kubernetes commands.
cmd/kubeadm
should be used only for the UXpkg/kubeadm
should be introduces and hostapis
and all the other kubeadm packagesAdditionally IMO:
pkg/kubeadm
sub treepkg/kubeadm
(e.g. printf/kubeadm output)The text was updated successfully, but these errors were encountered: