run linters from root

Signed-off-by: Aviv Turgeman <[email protected]>

Author: avivtur

.eslintrc.js

@@ -64,5 +64,5 @@ module.exports = {
       version: 'detect',
     },
   },
-  ignorePatterns: ['dist/', 'generated/', 'node_modules/', 'storybook-static/'],
+  ignorePatterns: ['dist/', 'distlib/', 'generated/', 'node_modules/', 'storybook-static/'],
 };

.prettierrc.js

@@ -6,4 +6,5 @@ module.exports = {
     singleQuote: true,
     trailingComma: 'all',
     bracketSpacing: true,
+    arrowParens: 'always',
 };

packages/common/src/components/Filter/DateFilter.tsx

@@ -3,7 +3,6 @@ import React, { FormEvent, useState } from 'react';
 import { DatePicker, InputGroup, ToolbarFilter } from '@patternfly/react-core';
 
 import { changeFormatToISODate, isValidDate, parseISOtoJSDate, toISODate } from '../../utils';
-
 import { FilterTypeProps } from './types';
 
 /**

packages/common/src/components/Filter/DateRangeFilter.tsx

@@ -17,7 +17,6 @@ import {
   toISODate,
   toISODateInterval,
 } from '../../utils';
-
 import { FilterTypeProps } from './types';
 
 /**

packages/common/src/components/Filter/EnumFilter.tsx

@@ -12,7 +12,6 @@ import {
 } from '@patternfly/react-core';
 
 import { localeCompare } from '../../utils';
-
 import { FilterTypeProps } from './types';
 
 /**

packages/common/src/components/FilterGroup/FilterFromDef.tsx

@@ -2,7 +2,6 @@ import React from 'react';
 
 import { FilterDef } from '../../utils';
 import { FilterTypeProps } from '../Filter';
-
 import { GlobalFilters } from './types';
 
 interface FilterFromDefProps {

packages/common/src/components/FilterGroup/helpers.ts

@@ -1,5 +1,4 @@
 import { ResourceField } from '../../utils';
-
 import { FieldFilter } from './types';
 
 export const toFieldFilter =

packages/common/src/components/FilterGroup/matchers.ts

@@ -9,7 +9,6 @@ import {
   GroupedEnumFilter,
   SwitchFilter,
 } from '../Filter';
-
 import { FilterRenderer, ValueMatcher } from './types';
 
 /**

packages/common/src/components/FilterGroup/useUrlFilters.ts

@@ -3,7 +3,6 @@ import { useMemo, useState } from 'react';
 import { useSearchParams } from '../../hooks/useSearchParams';
 import { ResourceField } from '../../utils';
 import { UserSettings } from '../Page';
-
 import { GlobalFilters } from './types';
 
 /**

packages/common/src/components/Page/useFields.tsx

@@ -1,7 +1,6 @@
 import { useMemo, useState } from 'react';
 
 import { NAMESPACE, ResourceField } from '../../utils';
-
 import { FieldSettings } from './types';
 
 const sameOrderAndVisibility = (a: ResourceField[], b: ResourceField[]): boolean => {

packages/common/src/components/Page/userSettings.ts

@@ -1,5 +1,4 @@
 import { loadFromLocalStorage, removeFromLocalStorage, saveToLocalStorage } from '../../utils';
-
 import { UserSettings } from './types';
 
 const parseOrClean = (key) => {

packages/common/src/components/TableView/DefaultRow.tsx

@@ -3,7 +3,6 @@ import React from 'react';
 import { Td, Tr } from '@patternfly/react-table';
 
 import { getResourceFieldValue } from '../FilterGroup';
-
 import { RowProps } from './types';
 
 /**

packages/common/src/components/TableView/TableView.tsx

@@ -4,7 +4,6 @@ import { Bullseye } from '@patternfly/react-core';
 import { Table, Tbody, Td, Thead, Tr } from '@patternfly/react-table';
 
 import { ResourceField, UID } from '../../utils';
-
 import { RowProps, SortType, TableViewHeaderProps } from './types';
 
 /**

packages/common/src/components/TableView/sort.ts

@@ -76,7 +76,7 @@ export const useSort = (
       compareWith(
         activeSort,
         resolvedLanguage,
-        fields.find(field => field.resourceFieldId === activeSort.resourceFieldId)?.compareFn,
+        fields.find((field) => field.resourceFieldId === activeSort.resourceFieldId)?.compareFn,
         fields,
       ),
     [fields, activeSort],

packages/forklift-console-plugin/src/components/common/ProjectNameSelect.tsx

@@ -63,7 +63,7 @@ export const useProjectNameSelectOptions = (defaultProject: string): TypeaheadSe
   return projects.length === 0 || !projectsLoaded || projectsLoadError
     ? // In case of an error or an empty list, returns the active namespace
       [{ value: defaultProject, content: defaultProject }]
-    : projects.map(project => ({
+    : projects.map((project) => ({
         value: project.metadata?.name,
         content: project.metadata?.name,
       }));

packages/forklift-console-plugin/src/components/page/StandardPage.tsx

@@ -47,7 +47,6 @@ import {
   TableSortContextProvider,
   useTableSortContext,
 } from '../TableSortContext';
-
 import { ManageColumnsToolbar } from './ManageColumnsToolbar';
 
 import './StandardPage.style.css';

packages/forklift-console-plugin/src/modules/NetworkMaps/actions/NetworkMapActionsDropdown.tsx

@@ -13,7 +13,6 @@ import {
 import { EllipsisVIcon } from '@patternfly/react-icons';
 
 import { CellProps } from '../views/list/components';
-
 import { NetworkMapActionsDropdownItems } from './NetworkMapActionsDropdownItems';
 
 import './NetworkMapActionsDropdown.style.css';

packages/forklift-console-plugin/src/modules/NetworkMaps/views/list/NetworkMapRow.tsx

@@ -5,7 +5,6 @@ import { Td, Tr } from '@patternfly/react-table';
 
 import { NetworkMapActionsDropdown } from '../../actions';
 import { NetworkMapData } from '../../utils';
-
 import {
   CellProps,
   NamespaceCell,

packages/forklift-console-plugin/src/modules/NetworkMaps/views/list/NetworkMapsListPage.tsx

@@ -14,7 +14,6 @@ import { useK8sWatchResource } from '@openshift-console/dynamic-plugin-sdk';
 import { NetworkMapsAddButton } from '../../components';
 import NetworkMapsEmptyState from '../../components/NetworkMapsEmptyState';
 import { getNetworkMapPhase, NETWORK_MAP_STATUS, NetworkMapData } from '../../utils';
-
 import NetworkMapRow from './NetworkMapRow';
 
 import './NetworkMapsListPage.style.css';

packages/forklift-console-plugin/src/modules/Overview/views/overview/OverviewPage.tsx

@@ -5,11 +5,10 @@ import { useForkliftTranslation } from 'src/utils/i18n';
 import { HorizontalNav, K8sModel } from '@openshift-console/dynamic-plugin-sdk';
 import { PageSection } from '@patternfly/react-core';
 
-import { useK8sWatchForkliftController, useProvidersInventoryIsLive } from '../../hooks';
-import { getOperatorPhase } from '../../utils/helpers/getOperatorPhase';
-
 import OperatorStatus from './components/OperatorStatus';
 import { ShowWelcomeCardButton } from './components/ShowWelcomeCardButton';
+import { useK8sWatchForkliftController, useProvidersInventoryIsLive } from '../../hooks';
+import { getOperatorPhase } from '../../utils/helpers/getOperatorPhase';
 import { HeaderTitle } from './components';
 import {
   ForkliftControllerDetailsTab,

packages/forklift-console-plugin/src/modules/Overview/views/overview/tabs/Metrics/cards/MigrationsChartCard.tsx

@@ -23,7 +23,6 @@ import chart_color_red_100 from '@patternfly/react-tokens/dist/esm/chart_color_r
 
 import { TimeRangeOptions, TimeRangeOptionsDictionary } from '../utils/timeRangeOptions';
 import { MigrationDataPoint, toDataPoints } from '../utils/toDataPointsHelper';
-
 import { MigrationsCardProps } from './MigrationsCard';
 
 const toStartedMigration = (m: V1beta1Migration): string => m.status.started;

packages/forklift-console-plugin/src/modules/Overview/views/overview/tabs/Metrics/cards/VmMigrationsChartCard.tsx

@@ -27,7 +27,6 @@ import chart_color_red_100 from '@patternfly/react-tokens/dist/esm/chart_color_r
 
 import { TimeRangeOptions, TimeRangeOptionsDictionary } from '../utils/timeRangeOptions';
 import { MigrationDataPoint, toDataPoints } from '../utils/toDataPointsHelper';
-
 import { MigrationsCardProps } from './MigrationsCard';
 
 const toStartedVmMigration = (v: V1beta1MigrationStatusVms): string => v.started;

packages/forklift-console-plugin/src/modules/Plans/actions/PlanActionsDropdown.tsx

@@ -6,7 +6,6 @@ import { Dropdown, DropdownList, MenuToggle, MenuToggleElement } from '@patternf
 import { EllipsisVIcon } from '@patternfly/react-icons';
 
 import { CellProps } from '../views/list/components';
-
 import { PlanActionsDropdownItems } from './PlanActionsDropdownItems';
 
 import './PlanActionsDropdown.style.css';

packages/forklift-console-plugin/src/modules/Plans/components/PlansEmptyState.tsx

@@ -10,7 +10,6 @@ import { ProviderModelRef } from '@kubev2v/types';
 import { Button, Flex, FlexItem } from '@patternfly/react-core';
 
 import digitalTransformation from '../..//Overview/images/digitalTransormation.svg';
-
 import PlansAddButton from './PlansAddButton';
 
 const HELP_LINK_HREF =

packages/forklift-console-plugin/src/modules/Plans/views/create/PlanCreatePage.tsx

@@ -20,7 +20,6 @@ import { useActiveNamespace, useK8sWatchResource } from '@openshift-console/dyna
 import { PageSection, Title, Wizard, WizardStep } from '@patternfly/react-core';
 
 import { anyValidationErrorExists } from '../../utils';
-
 import { findProviderByID } from './components';
 import { planCreatePageInitialState, planCreatePageReducer } from './states';
 import { SelectSourceProvider } from './steps';

packages/forklift-console-plugin/src/modules/Plans/views/create/components/FiltersToolbarProviders.tsx

@@ -3,7 +3,6 @@ import React from 'react';
 import { Toolbar, ToolbarContent, ToolbarItem } from '@patternfly/react-core';
 
 import { PlanCreatePageState } from '../states';
-
 import SearchInputProvider from './SearchInputProvider';
 import SelectProvider from './SelectProvider';
 

packages/forklift-console-plugin/src/modules/Plans/views/create/components/PlanCreateForm.tsx

@@ -26,7 +26,6 @@ import {
 } from '@patternfly/react-core';
 
 import { PlanCreatePageState } from '../states';
-
 import { ChipsToolbarProviders } from './ChipsToolbarProviders';
 import { createProviderCardItems } from './createProviderCardItems';
 import { FiltersToolbarProviders } from './FiltersToolbarProviders';

packages/forklift-console-plugin/src/modules/Plans/views/create/components/createProviderCardItems.tsx

@@ -4,7 +4,6 @@ import { SelectableGalleryItem } from 'src/modules/Providers/utils/components/Ga
 import { V1beta1Provider } from '@kubev2v/types';
 
 import providerTypes from '../constanats/providerTypes';
-
 import { ProviderCardContent } from './ProviderCardContent';
 import { ProviderCardTitle } from './providerCardTitle';
 

packages/forklift-console-plugin/src/modules/Plans/views/create/steps/SelectSourceProvider/SelectSourceProvider.tsx

@@ -6,9 +6,8 @@ import { useForkliftTranslation } from 'src/utils/i18n';
 import { V1beta1Provider } from '@kubev2v/types';
 import { Title } from '@patternfly/react-core';
 
-import { PlanCreatePageActionTypes, PlanCreatePageState } from '../../states';
-
 import { PlanCreateForm } from './../../components';
+import { PlanCreatePageActionTypes, PlanCreatePageState } from '../../states';
 import { MemoizedProviderVirtualMachinesList } from './MemoizedProviderVirtualMachinesList';
 
 export const SelectSourceProvider: React.FC<{

packages/forklift-console-plugin/src/modules/Plans/views/details/components/MigrationsSection/MigrationsSection.tsx

@@ -4,7 +4,6 @@ import { MigrationModelGroupVersionKind, V1beta1Migration, V1beta1Plan } from '@
 import { useK8sWatchResource } from '@openshift-console/dynamic-plugin-sdk';
 
 import { Suspend } from '../Suspend';
-
 import { MigrationsTable } from './components';
 
 export const MigrationsSection: React.FC<MigrationsSectionProps> = ({ obj }) => {

packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/NameTemplate/utils/utils.ts

@@ -5,7 +5,6 @@ import { setObjectValueByPath, unsetObjectValueByPath } from 'src/utils/utils';
 import { k8sUpdate } from '@openshift-console/dynamic-plugin-sdk';
 
 import { EnhancedPlan } from '../../../utils/types';
-
 import { NameTemplateRadioOptions } from './constants';
 
 export const onConfirmNameTemplate: (selected: NameTemplateRadioOptions) => OnConfirmHookType =

packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/NetworkNameTemplate/NetworkNameTemplateDetailsItem.tsx

@@ -6,7 +6,6 @@ import { useForkliftTranslation } from 'src/utils/i18n';
 
 import { PlanDetailsItemProps } from '../../../DetailsSection';
 import { EnhancedPlan } from '../../utils/types';
-
 import NetworkNameTemplateModal from './NetworkNameTemplateModal';
 
 const NetworkNameTemplateDetailsItem: FC<PlanDetailsItemProps> = ({ resource, canPatch }) => {

packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/NetworkNameTemplate/NetworkNameTemplateModal.tsx

@@ -1,15 +1,14 @@
 import React, { FC } from 'react';
 import { useForkliftTranslation } from 'src/utils';
 
-import { SettingsEditModalProps } from '../../utils/types';
-import NameTemplateModalBody from '../NameTemplate/NameTemplateModal/components/NameTemplateModalBody/NameTemplateModalBody';
-import NameTemplateModalHelper from '../NameTemplate/NameTemplateModal/components/NameTemplateModalHelper/NameTemplateModalHelper';
-import NameTemplateModal from '../NameTemplate/NameTemplateModal/NameTemplateModal';
-
 import {
   getNetworkNameTemplateAllowedVariables,
   networkNameTemplateHelperExamples,
 } from './utils/constants';
+import { SettingsEditModalProps } from '../../utils/types';
+import NameTemplateModalBody from '../NameTemplate/NameTemplateModal/components/NameTemplateModalBody/NameTemplateModalBody';
+import NameTemplateModalHelper from '../NameTemplate/NameTemplateModal/components/NameTemplateModalHelper/NameTemplateModalHelper';
+import NameTemplateModal from '../NameTemplate/NameTemplateModal/NameTemplateModal';
 
 const NetworkNameTemplateModal: FC<SettingsEditModalProps> = ({ title, jsonPath, resource }) => {
   const { t } = useForkliftTranslation();

packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/PVCNameTemplate/PVCNameTemplateDetailsItem.tsx

@@ -6,7 +6,6 @@ import { useForkliftTranslation } from 'src/utils/i18n';
 
 import { PlanDetailsItemProps } from '../../../DetailsSection';
 import { EnhancedPlan } from '../../utils/types';
-
 import PVCNameTemplateModal from './PVCNameTemplateModal';
 
 const PVCNameTemplateDetailsItem: FC<PlanDetailsItemProps> = ({ resource, canPatch }) => {

packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/PVCNameTemplate/PVCNameTemplateModal.tsx

@@ -1,15 +1,14 @@
 import React, { FC } from 'react';
 import { useForkliftTranslation } from 'src/utils';
 
-import { SettingsEditModalProps } from '../../utils/types';
-import NameTemplateModalBody from '../NameTemplate/NameTemplateModal/components/NameTemplateModalBody/NameTemplateModalBody';
-import NameTemplateModalHelper from '../NameTemplate/NameTemplateModal/components/NameTemplateModalHelper/NameTemplateModalHelper';
-import NameTemplateModal from '../NameTemplate/NameTemplateModal/NameTemplateModal';
-
 import {
   getPVCNameTemplateAllowedVariables,
   pvcNameTemplateHelperExamples,
 } from './utils/constants';
+import { SettingsEditModalProps } from '../../utils/types';
+import NameTemplateModalBody from '../NameTemplate/NameTemplateModal/components/NameTemplateModalBody/NameTemplateModalBody';
+import NameTemplateModalHelper from '../NameTemplate/NameTemplateModal/components/NameTemplateModalHelper/NameTemplateModalHelper';
+import NameTemplateModal from '../NameTemplate/NameTemplateModal/NameTemplateModal';
 
 const PVCNameTemplateModal: FC<SettingsEditModalProps> = ({ title, jsonPath, resource }) => {
   const { t } = useForkliftTranslation();

packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/SharedDisksDetailsItem/SharedDisksDetailsItem.tsx

@@ -4,10 +4,9 @@ import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
 
-import { PlanDetailsItemProps } from '../../../DetailsSection';
-
 import MigrateSharedDisksModal from './components/MigrateSharedDisksModal/MigrateSharedDisksModal';
 import { getMigrateSharedDisks } from './utils/helpers';
+import { PlanDetailsItemProps } from '../../../DetailsSection';
 
 const SharedDisksDetailsItem: FC<PlanDetailsItemProps> = ({ resource, canPatch }) => {
   const { t } = useForkliftTranslation();

packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/VolumeNameTemplate/VolumeNameTemplateDetailsItem.tsx

@@ -6,7 +6,6 @@ import { useForkliftTranslation } from 'src/utils/i18n';
 
 import { PlanDetailsItemProps } from '../../../DetailsSection';
 import { EnhancedPlan } from '../../utils/types';
-
 import VolumeNameTemplateModal from './VolumeNameTemplateModal';
 
 const VolumeNameTemplateDetailsItem: FC<PlanDetailsItemProps> = ({ resource, canPatch }) => {

packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/components/VolumeNameTemplate/VolumeNameTemplateModal.tsx

@@ -1,15 +1,14 @@
 import React, { FC } from 'react';
 import { useForkliftTranslation } from 'src/utils';
 
-import { SettingsEditModalProps } from '../../utils/types';
-import NameTemplateModalBody from '../NameTemplate/NameTemplateModal/components/NameTemplateModalBody/NameTemplateModalBody';
-import NameTemplateModalHelper from '../NameTemplate/NameTemplateModal/components/NameTemplateModalHelper/NameTemplateModalHelper';
-import NameTemplateModal from '../NameTemplate/NameTemplateModal/NameTemplateModal';
-
 import {
   getVolumeNameTemplateAllowedVariables,
   volumeNameTemplateHelperExamples,
 } from './utils/constants';
+import { SettingsEditModalProps } from '../../utils/types';
+import NameTemplateModalBody from '../NameTemplate/NameTemplateModal/components/NameTemplateModalBody/NameTemplateModalBody';
+import NameTemplateModalHelper from '../NameTemplate/NameTemplateModal/components/NameTemplateModalHelper/NameTemplateModalHelper';
+import NameTemplateModal from '../NameTemplate/NameTemplateModal/NameTemplateModal';
 
 const VolumeNameTemplateModal: FC<SettingsEditModalProps> = ({ title, jsonPath, resource }) => {
   const { t } = useForkliftTranslation();

packages/forklift-console-plugin/src/modules/Plans/views/details/tabs/Hooks/PlanHooks.tsx

@@ -21,7 +21,6 @@ import {
 } from '@patternfly/react-core';
 
 import { Suspend } from '../../components';
-
 import { usePlanHooks } from './hooks';
 import { formReducer, initialState } from './state';
 import { onUpdatePlanHooks } from './utils';

packages/forklift-console-plugin/src/modules/Plans/views/details/tabs/Hooks/utils/onUpdatePlanHooks.tsx

@@ -5,7 +5,6 @@ import { deepCopy } from 'src/utils';
 import { V1beta1Hook, V1beta1Plan } from '@kubev2v/types';
 
 import { FormAction, FormState } from '../state';
-
 import { createHook } from './createHook';
 import { deleteHook } from './deleteHook';
 import { updateHook } from './updateHook';

packages/forklift-console-plugin/src/modules/Plans/views/details/tabs/Resources/PlanResources.tsx

@@ -17,7 +17,6 @@ import { useK8sWatchResource } from '@openshift-console/dynamic-plugin-sdk';
 import { Bullseye } from '@patternfly/react-core';
 
 import { Loading, Suspend } from '../../components';
-
 import { OpenshiftPlanResources } from './OpenshiftPlanResources';
 import { OpenstackPlanResources } from './OpenstackPlanResources';
 import { OVAPlanResources } from './OVAPlanResources';

packages/forklift-console-plugin/src/modules/Plans/views/details/tabs/VirtualMachines/Migration/MigrationVirtualMachinesList.tsx

@@ -23,7 +23,6 @@ import { HelperText, HelperTextItem } from '@patternfly/react-core';
 
 import { MigrationVMsCancelButton, PlanVMsDeleteButton } from '../components';
 import { PlanData, VMData } from '../types';
-
 import { MigrationVirtualMachinesRow } from './MigrationVirtualMachinesRow';
 import { MigrationVirtualMachinesRowExtended } from './MigrationVirtualMachinesRowExtended';
 

packages/forklift-console-plugin/src/modules/Plans/views/details/tabs/VirtualMachines/Migration/MigrationVirtualMachinesRowExtended.tsx

@@ -30,7 +30,6 @@ import { Table, Tbody, Td, Th, Thead, Tr } from '@patternfly/react-table';
 import { hasTaskCompleted } from '../../../utils';
 import { PipelineTasksModal } from '../modals';
 import { VMData } from '../types';
-
 import { getIcon, getVariant } from './MigrationVirtualMachinesRow';
 
 export const MigrationVirtualMachinesRowExtended: React.FC<RowProps<VMData>> = (props) => {

packages/forklift-console-plugin/src/modules/Plans/views/details/tabs/VirtualMachines/Plan/ActionsCell.tsx

@@ -4,7 +4,6 @@ import { ModalHOC } from 'src/modules/Providers';
 import { Flex, FlexItem } from '@patternfly/react-core';
 
 import { PlanVMsCellProps } from '../components';
-
 import PlanVMActionsDropdown from './PlanVMActionsDropdown';
 
 const ActionsCell: FC<PlanVMsCellProps> = ({ data: vm }) => {