From d74e9288892d923f38338689a4c363a1bba3374e Mon Sep 17 00:00:00 2001
From: Aviv Turgeman <aturgema@redhat.com>
Date: Wed, 19 Mar 2025 13:51:56 +0200
Subject: [PATCH] Present template naming fields only for vsphere provider

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
---
 .../SettingsSection/SettingsSection.tsx       | 23 ++++++++++---------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/SettingsSection.tsx b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/SettingsSection.tsx
index b6cccc0d4..aaca5b9c0 100644
--- a/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/SettingsSection.tsx
+++ b/packages/forklift-console-plugin/src/modules/Plans/views/details/components/SettingsSection/SettingsSection.tsx
@@ -46,6 +46,7 @@ export const SettingsSectionInternal: React.FC<SettingsSectionProps> = ({ obj, p
     namespace: obj?.spec?.provider?.destination?.namespace,
   });
 
+  const isVsphere = sourceProvider?.spec?.type === 'vsphere';
   return (
     <>
       <DescriptionList
@@ -73,27 +74,27 @@ export const SettingsSectionInternal: React.FC<SettingsSectionProps> = ({ obj, p
           <PreserveClusterCpuModelDetailsItem resource={obj} canPatch={permissions.canPatch} />
         )}
 
-        {['vsphere'].includes(sourceProvider?.spec?.type) && (
+        {isVsphere && (
           <PreserveStaticIPsDetailsItem resource={obj} canPatch={permissions.canPatch} />
         )}
 
-        {['vsphere'].includes(sourceProvider?.spec?.type) && (
+        {isVsphere && (
           <SetLUKSEncryptionPasswordsDetailsItem resource={obj} canPatch={permissions.canPatch} />
         )}
 
-        {['vsphere'].includes(sourceProvider?.spec?.type) && (
-          <RootDiskDetailsItem resource={obj} canPatch={permissions.canPatch} />
-        )}
+        {isVsphere && <RootDiskDetailsItem resource={obj} canPatch={permissions.canPatch} />}
 
-        {['vsphere'].includes(sourceProvider?.spec?.type) && (
-          <SharedDisksDetailsItem resource={obj} canPatch={permissions.canPatch} />
-        )}
+        {isVsphere && <SharedDisksDetailsItem resource={obj} canPatch={permissions.canPatch} />}
 
-        <PVCNameTemplateDetailsItem resource={obj} canPatch={permissions.canPatch} />
+        {isVsphere && <PVCNameTemplateDetailsItem resource={obj} canPatch={permissions.canPatch} />}
 
-        <VolumeNameTemplateDetailsItem resource={obj} canPatch={permissions.canPatch} />
+        {isVsphere && (
+          <VolumeNameTemplateDetailsItem resource={obj} canPatch={permissions.canPatch} />
+        )}
 
-        <NetworkNameTemplateDetailsItem resource={obj} canPatch={permissions.canPatch} />
+        {isVsphere && (
+          <NetworkNameTemplateDetailsItem resource={obj} canPatch={permissions.canPatch} />
+        )}
       </DescriptionList>
     </>
   );