Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Addon] Chartmuseum add a cache refresh option #751

Closed
wants to merge 6 commits into from
Closed

[Addon] Chartmuseum add a cache refresh option #751

wants to merge 6 commits into from

Conversation

oanasc
Copy link
Contributor

@oanasc oanasc commented Apr 11, 2024

Description of your changes

Add an option to change the default configuration of the default cache refresh interval, the default is causing us to have stale charts and failing releases.

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

@charlie0129
Copy link
Member

LGTM! Thank you. Please fix the DCO so I can merge your PR.

@oanasc
Copy link
Contributor Author

oanasc commented Apr 11, 2024

DCO key resolved

Kolossi and others added 6 commits April 11, 2024 13:59
@Kolossi @oanasc
[Addon] update datadog trait (kubevela#750)
7f6fc03 
Signed-off-by: kolossi <[email protected]>
Co-authored-by: kolossi <[email protected]>
Signed-off-by: Oana Schipor <[email protected]>
@oanasc
Add an option to set the cache refresh interval
7dbbc65 
Signed-off-by: Oana Schipor <[email protected]>
@oanasc
Add an option to set the cache refresh interval
a70036c 
Signed-off-by: Oana Schipor <[email protected]>
@oanasc
fix type
9e1b56e 
Signed-off-by: Oana Schipor <[email protected]>
@oanasc
Trigger DCO
7256ed2 
Signed-off-by: Oana Schipor <[email protected]>
@oanasc @charlie0129
Update addons/chartmuseum/resources/parameter.cue
e52d8f4 
Co-authored-by: Charlie Chiang <[email protected]>
Signed-off-by: Oana Schipor <[email protected]>
@oanasc
Copy link
Contributor Author

oanasc commented Apr 11, 2024

rebase gone wrong

@oanasc oanasc closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlie0129 charlie0129 charlie0129 left review comments

@wangyikewxgm wangyikewxgm Awaiting requested review from wangyikewxgm wangyikewxgm is a code owner

@wonderflow wonderflow Awaiting requested review from wonderflow wonderflow is a code owner

@barnettZQG barnettZQG Awaiting requested review from barnettZQG barnettZQG is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oanasc @charlie0129 @Kolossi