Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon] Chartmuseum add a cache refresh option #751 #752

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

oanasc
Copy link
Contributor

@oanasc oanasc commented Apr 11, 2024

Description of your changes

Add an option to change the default configuration of the default cache refresh interval, the default is causing us to have stale charts and failing releases.

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

@oanasc
Copy link
Contributor Author

oanasc commented Apr 11, 2024

@charlie0129 Trying this again (my rebase broke a cardinal rule - rebased an empty commit) and have reopened as a fresh branch/PR. Thanks

Copy link
Member

@charlie0129 charlie0129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlie0129 charlie0129 merged commit 1e13df0 into kubevela:master Apr 11, 2024
3 checks passed
@oanasc oanasc deleted the cm-state branch April 12, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants