Remove requeue from clone populator

alromeros · alromeros · commit 813832d4cb81 · 2025-02-19T17:54:49.000+01:00
Since now we have specific watches for both clone sources (PVC and VolumeSnapshot), there's no need to force a requeue if source PVC is not ready.

Signed-off-by: Alvaro Romero &lt;alromero@redhat.com&gt;
diff --git a/pkg/controller/clone/csi-clone.go b/pkg/controller/clone/csi-clone.go
@@ -3,7 +3,6 @@ package clone
 import (
 	"context"
 	"fmt"
-	"time"
 
 	"github.com/go-logr/logr"
 
@@ -63,8 +62,7 @@ func (p *CSIClonePhase) Reconcile(ctx context.Context) (*reconcile.Result, error
 		}
 
 		if !ready {
-			// TODO - maybe make this event based
-			return &reconcile.Result{RequeueAfter: 2 * time.Second}, nil
+			return &reconcile.Result{}, nil
 		}
 
 		pvc, err = p.createClaim(ctx)

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@ package clone`
`3`	`3`	`import (`
`4`	`4`	`"context"`
`5`	`5`	`"fmt"`
`6`		`- "time"`
`7`	`6`
`8`	`7`	`"github.com/go-logr/logr"`
`9`	`8`
`@@ -63,8 +62,7 @@ func (p CSIClonePhase) Reconcile(ctx context.Context) (reconcile.Result, error`
`63`	`62`	`}`
`64`	`63`
`65`	`64`	`if !ready {`
`66`		`- // TODO - maybe make this event based`
`67`		`- return &reconcile.Result{RequeueAfter: 2 * time.Second}, nil`
	`65`	`+ return &reconcile.Result{}, nil`
`68`	`66`	`}`
`69`	`67`
`70`	`68`	`pvc, err = p.createClaim(ctx)`