Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAPI specs for (at least) Mesh*Service are missing query params #11339

Open
johncowen opened this issue Sep 9, 2024 · 0 comments
Open

OpenAPI specs for (at least) Mesh*Service are missing query params #11339

johncowen opened this issue Sep 9, 2024 · 0 comments
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@johncowen
Copy link
Contributor

johncowen commented Sep 9, 2024 •
edited
Loading

What happened?

See kumahq/kuma-gui#2877:

I also noticed that the types seem to be wrong for the HTTP requests (specifically ?offset&size&format are missing). I've @ts-ignore those until they are updated upstream so we can move forwards with this work in the meantime.

https://github.com/kumahq/kuma-gui/blob/b12fdaa7a13ad44fbfc8c9c1b4db5f86c301ec03/src/app/services/sources.ts#L90-L94

Note this isn't required for 2.9, just at any point after
@johncowen johncowen added kind/bug A bug triage/pending This issue will be looked at on the next triage meeting labels Sep 9, 2024
@michaelbeaumont michaelbeaumont added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johncowen @michaelbeaumont