Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the resources properties to be compatible with Terraform and OpenAPI generator #12845

Open
slonka opened this issue Feb 13, 2025 · 0 comments · May be fixed by #12895
Open

Update the resources properties to be compatible with Terraform and OpenAPI generator #12845

slonka opened this issue Feb 13, 2025 · 0 comments · May be fixed by #12895
Assignees
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@slonka
Copy link
Contributor

slonka commented Feb 13, 2025

Description

This is a mirror of #12790 but for resources (Mesh, MeshGateway, MeshExternalService, MeshService, MeshMultizoneService)

Description

We identified 4 types of properties:

  • mergable
  • non mergeable, user optional, with default
  • non mergeable, user optional, without default
  • non mergeable, user required

The full doc: https://docs.google.com/document/d/1ZV8KaXr1kV4P5O-eq4gy5IxSMJQ4VzvTT-BmeBABuDo/edit?tab=t.0

We should modify the properties and have a linter to check that we're not introducing new fields that don't match.

Parent issue: https://github.com/Kong/kong-mesh/issues/7206

For proto we should use google.protobuf.BoolValue skipMTLS = 4; so when user sets this to false then API returns false

@slonka slonka added kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it labels Feb 13, 2025
@slonka slonka self-assigned this Feb 20, 2025
@slonka slonka linked a pull request Feb 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant