Loading .nkg file fails on Windows

[caiw]

Discovered when trying to fix #408

[caiw]

@young-x-skyee I'm here to help with this where I can!

[young-x-skyee]

Thanks a lot, Cai! I'll be in CBU on Monday and post the details about the bug then.

[young-x-skyee]

When I'm running the script using the old packages, I got this error

I don't get this error on Linux machines opening the same file, and neither does @neukym on his Mac.

We have confirmed that the dimensions of both coords and data are the same on the Mac (therefore no error), but for Windows the second dimension of coords is doubled what it should be.

nkg.py reads in the coords using:

 with zf.open(f"/{block_name}/coo-coords.bytes") as f:
                coords: NDArray = frombuffer(f.read(), dtype=int).reshape((3, -1))

Could this not work on windows somehow?

[caiw]

This is super weird. Good job tracking down the error. Do the unit tests run on Windows?

[caiw]

One more Q: this issue suggests the issue arrises in particular when doing expression plots with minimaps - I think that's something I heard from @neukym. Is this actually a key part of causing the error or is it just a coincidence that that's what you were trying to do when you noticed it? (Sorry if it's my misunderstanding!)

[neukym]

Correct! This latest issue is not related to the minimaps - we found it while trying to fix that problem. We should split this into a new issue.

[caiw]

Ok, this one has details of the .nkg issue so I'll rename it and make a new one for the minimaps (#408)

[sharonho1215]

I have this problem too when trying to open this on a windows machine :(