We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hemisphere merging code currently looks like this:
for func, spike in spikes.items(): extracted_spikes = spike.right_best_pairings if self._hemi == HEMI_RIGHT else spike.left_best_pairings if self._should_merge_hemis: other_hemi_spikes = spike.left_best_pairings if self._hemi == HEMI_LEFT else spike.right_best_pairings extracted_spikes.extend(other_hemi_spikes)
Shouldn't it be
# v other_hemi_spikes = spike.left_best_pairings if self._hemi == HEMI_RIGHT else spike.right_best_pairings
since it's selecting the other hemisphere's pairings?
I've tried making this change, but then some tests fail (see #439) :/
The text was updated successfully, but these errors were encountered:
I'm mainly hoping to make sure the tests are correct so I can use them for the #391 refactor
Sorry, something went wrong.
anirudh1666
Successfully merging a pull request may close this issue.
Hemisphere merging code currently looks like this:
Shouldn't it be
since it's selecting the other hemisphere's pairings?
I've tried making this change, but then some tests fail (see #439) :/
The text was updated successfully, but these errors were encountered: