Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPPM: Is hemisphere merging done correctly? #438

Open
caiw opened this issue Feb 14, 2025 · 1 comment · May be fixed by #391 or #439
Open

IPPM: Is hemisphere merging done correctly? #438

caiw opened this issue Feb 14, 2025 · 1 comment · May be fixed by #391 or #439
Assignees
Labels

Comments

@caiw
Copy link
Member

caiw commented Feb 14, 2025

Hemisphere merging code currently looks like this:

for func, spike in spikes.items():
    extracted_spikes = spike.right_best_pairings if self._hemi == HEMI_RIGHT else spike.left_best_pairings
    if self._should_merge_hemis:
        other_hemi_spikes = spike.left_best_pairings if self._hemi == HEMI_LEFT else spike.right_best_pairings
        extracted_spikes.extend(other_hemi_spikes)

Shouldn't it be

#                                                                         v
        other_hemi_spikes = spike.left_best_pairings if self._hemi == HEMI_RIGHT else spike.right_best_pairings

since it's selecting the other hemisphere's pairings?

I've tried making this change, but then some tests fail (see #439) :/

@caiw caiw added IPPM generation 🪲 bug Something isn't working labels Feb 14, 2025
@caiw
Copy link
Member Author

caiw commented Feb 14, 2025

I'm mainly hoping to make sure the tests are correct so I can use them for the #391 refactor

This was referenced Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants