Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish java core package when release a new verison of lance #3372

Open
SaintBacchus opened this issue Jan 13, 2025 · 4 comments
Open

Publish java core package when release a new verison of lance #3372

SaintBacchus opened this issue Jan 13, 2025 · 4 comments

Comments

@SaintBacchus
Copy link
Collaborator

SaintBacchus commented Jan 13, 2025

The maven repository only has ancient versions of lance java package.

image

The new version of java package was not published to maven repository.

As discussed in trinodb/trino#21880, now the Lance Core is much smaller than before.

Maybe we should release a new version of java core package to make Trino lance connector merged.

cc @wjones127

@SaintBacchus
Copy link
Collaborator Author

The java publish workflow was already using the release version of lance.

mvn --batch-mode -DskipTests -Drust.release.build=true -DpushChanges=false -Dgpg.passphrase=${{ secrets.GPG_PASSPHRASE }} deploy -P deploy-to-ossrh -P shade-jar

https://github.com/lancedb/lance/blob/main/.github/workflows/java-publish.yml

@yanghua
Copy link
Collaborator

yanghua commented Jan 14, 2025

+1

IMO, we should establish some release specifications for Java modules.

@LuQQiu
Copy link
Contributor

LuQQiu commented Jan 14, 2025

https://github.com/lancedb/lance/actions/runs/12755910646
Looks like @wjones127 has triggered the java release yesterday, maybe run into some runner issue

@SaintBacchus
Copy link
Collaborator Author

@LuQQiu Thx for fixing the release issue. Can we release the 0.22.1 version this week for trino connector usage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants