Fix test failed in new PhpUnit (#2)

Author: slavcodev

.github/workflows/phpunit.yml

@@ -19,6 +19,9 @@ jobs:
           - 7.3
           - 7.4
           - 8.0
+          - 8.1
+          - 8.2
+          - 8.3
 
     env:
       EXECUTE_COVERAGE: ${{ matrix.php-version == '8.0' }}

tests/TestCase.php

@@ -4,4 +4,10 @@
 
 class TestCase extends \Orchestra\Testbench\TestCase
 {
+    // The TestCase::__construct in the new PHPUnit versions requires first argument,
+    // this workaround allows to instantiate test files in the tests.
+    public function __construct($name = null)
+    {
+        parent::__construct($name ?? get_class($this));
+    }
 }

tests/Unit/CardTest.php

@@ -10,17 +10,16 @@
 
 class CardTest extends TestCase
 {
-    /** @test @dataProvider badStrings **/
-    public function it_expects_card_number($input)
+    public function it_expects_card_number()
     {
         $this->expectException(CreditCardException::class);
-
-        Factory::makeFromNumber($input);
+        Factory::makeFromNumber(null);
     }
 
-    public function badStrings()
+    public function it_expects_not_empty_card_number()
     {
-        return ['empty string' => [''], 'null' => [null]];
+        $this->expectException(CreditCardException::class);
+        Factory::makeFromNumber('');
     }
 
     /** @test **/