simplify module store proxy

Author: jancajthaml

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lastui/rocker",
-  "version": "0.20.3",
+  "version": "0.20.4",
   "license": "Apache-2.0",
   "author": "[email protected]",
   "homepage": "https://github.com/lastui/rocker#readme",

platform/src/kernel/registry/__tests__/store.test.js

@@ -4,20 +4,16 @@ import { SET_SHARED } from "../../../constants";
 import { setStore, getStore } from "../store";
 
 describe("store registry", () => {
-  const ORIGINAL_NODE_ENV = process.env.NODE_ENV;
-
   const debugSpy = jest.spyOn(console, "debug").mockImplementation(() => {});
   const errorSpy = jest.spyOn(console, "error").mockImplementation(() => {});
 
   beforeEach(() => {
     setStore(null);
-    process.env.NODE_ENV = ORIGINAL_NODE_ENV;
     debugSpy.mockClear();
     errorSpy.mockClear();
   });
 
   afterAll(() => {
-    process.env.NODE_ENV = ORIGINAL_NODE_ENV;
     debugSpy.mockRestore();
     errorSpy.mockRestore();
   });
@@ -68,71 +64,7 @@ describe("store registry", () => {
     });
 
     describe("namespace", () => {
-      it(".getState in NODE_ENV=development", () => {
-        setStore(
-          configureStore([])({
-            modules: {
-              "my-feature": {
-                foo: "bat",
-              },
-              "my-other-feature": {
-                foo: "baz",
-              },
-            },
-            env: {},
-            shared: {
-              beach: "bar",
-            },
-          }),
-        );
-
-        process.env.NODE_ENV = "development";
-
-        const store = getStore().namespace("my-feature");
-
-        expect(typeof store.getState).toEqual("function");
-
-        const state = store.getState();
-
-        expect(state).toEqual(store.getState());
-
-        expect(state).toEqual({
-          foo: "bat",
-          env: {},
-          shared: {
-            beach: "bar",
-          },
-        });
-        expect(state.valueOf()).toEqual({
-          foo: "bat",
-          env: {},
-          shared: {
-            beach: "bar",
-          },
-        });
-        expect(state.toString()).toEqual("[object Object]");
-        expect(state.shared).toEqual({ beach: "bar" });
-        errorSpy.mockClear();
-
-        expect(state.other).toBeUndefined();
-        expect(errorSpy).toHaveBeenCalledWith('module "my-feature" tried to access reducer "other" that it does not own.');
-
-        expect("shared" in state).toEqual(true);
-        expect("foo" in state).toEqual(true);
-        expect("other" in state).toEqual(false);
-
-        expect(Reflect.ownKeys(state)).toEqual(["foo", "env", "shared"]);
-
-        state.foo = "mutation";
-
-        expect(() => {
-          state.shared.beach = "injection";
-        }).toThrow(TypeError);
-
-        expect(state.shared.beach).toEqual("bar");
-      });
-
-      it(".getState in NODE_ENV=production", () => {
+      it(".getState", () => {
         setStore(
           configureStore([])({
             modules: {
@@ -150,8 +82,6 @@ describe("store registry", () => {
           }),
         );
 
-        process.env.NODE_ENV = "production";
-
         let store = getStore().namespace("my-feature");
 
         expect(typeof store.getState).toEqual("function");

platform/src/kernel/registry/store.js

@@ -1,5 +1,4 @@
 import { SET_SHARED } from "../../constants";
-import { warning } from "../../utils";
 
 const RUNE = "$";
 const BROADCAST_ACTION_PREFIX = "@@";
@@ -72,61 +71,11 @@ const handler = {
           const state = store.getState();
           if (prevState !== state) {
             prevState = state;
-            if (process.env.NODE_ENV === "development") {
-              stateProxy = new Proxy(
-                {
-                  ...state.modules[name],
-                  env: state.env,
-                  shared: Object.freeze(state.shared),
-                },
-                {
-                  get(ref, reducer) {
-                    switch (reducer) {
-                      case Symbol.iterator: {
-                        return Reflect.get(ref, reducer);
-                      }
-                      case "toString":
-                      case Symbol.toStringTag: {
-                        return () => "[object Object]";
-                      }
-                      case "valueOf": {
-                        return () => ref;
-                      }
-                      default: {
-                        if (reducer in ref) {
-                          return ref[reducer];
-                        }
-                        warning(`module "${name}" tried to access reducer "${reducer}" that it does not own.`);
-                        return undefined;
-                      }
-                    }
-                  },
-                  has(ref, reducer) {
-                    return reducer in ref;
-                  },
-                  ownKeys(ref) {
-                    return Reflect.ownKeys(ref);
-                  },
-                  getOwnPropertyDescriptor(ref, key) {
-                    return {
-                      value: this.get(ref, key),
-                      enumerable: true,
-                      configurable: true,
-                    };
-                  },
-                  set(ref, reducer, value) {
-                    ref[reducer] = value;
-                    return true;
-                  },
-                },
-              );
-            } else {
-              stateProxy = {
-                ...state.modules[name],
-                env: state.env,
-                shared: Object.freeze(state.shared),
-              };
-            }
+            stateProxy = {
+              ...state.modules[name],
+              env: state.env,
+              shared: Object.freeze(state.shared),
+            };
           }
           return stateProxy;
         },