auto prefix non broadcast redux actions

Author: jancajthaml

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lastui/rocker",
-  "version": "0.19.25",
+  "version": "0.19.26",
   "license": "Apache-2.0",
   "author": "[email protected]",
   "homepage": "https://github.com/lastui/rocker#readme",

platform/src/kernel/reducer/__tests__/modules.test.js

@@ -81,11 +81,53 @@ describe("modules reducer", () => {
       };
 
       expect(reducer(state, action)).toEqual(expectedState);
+
       expect(reducer(expectedState, action)).toEqual(expectedState);
-      expect(spyError).toHaveBeenCalledWith(
-        "module my-feature-broken reducer failed to reduce on action non-handled",
-        new Error("ouch"),
-      );
+      expect(spyError).toHaveBeenCalledWith("module my-feature-broken reducer failed to reduce", new Error("ouch"));
+    });
+
+    it("handles broadcast action", () => {
+      const action = {
+        type: "@@FEATURE_BROADCASTING_A_THING",
+      };
+
+      modulesReducers["my-feature-sniff"] = (localState = {}, action) => ({
+        ...localState,
+        lastAction: action.type,
+      });
+      const state = {
+        ...initialState,
+      };
+      const expectedState = {
+        ...initialState,
+        "my-feature-sniff": {
+          lastAction: "@@FEATURE_BROADCASTING_A_THING",
+        },
+      };
+
+      expect(reducer(state, action)).toEqual(expectedState);
+    });
+
+    it("handles owned action", () => {
+      const action = {
+        type: "$my-feature-sniff$OWNED_ACTION",
+      };
+
+      modulesReducers["my-feature-sniff"] = (localState = {}, action) => ({
+        ...localState,
+        lastAction: action.type,
+      });
+      const state = {
+        ...initialState,
+      };
+      const expectedState = {
+        ...initialState,
+        "my-feature-sniff": {
+          lastAction: "OWNED_ACTION",
+        },
+      };
+
+      expect(reducer(state, action)).toEqual(expectedState);
     });
   });
 

platform/src/kernel/reducer/modules.js

@@ -1,6 +1,12 @@
 import * as constants from "../../constants";
 import { warning } from "../../utils";
 
+const BROADCAST_ACTION_PREFIX = "@@";
+
+const PROBE_ACTION = {
+  type: undefined,
+};
+
 const initial = {
   keys: [],
   values: [],
@@ -22,7 +28,7 @@ const handler = {
     }
     const index = target.keys.indexOf(prop);
     if (index !== -1) {
-      return target.values[index][1];
+      return target.values[index][2];
     }
     return undefined;
   },
@@ -33,9 +39,9 @@ const handler = {
     const index = obj.keys.indexOf(prop);
     if (index === -1) {
       obj.keys.push(prop);
-      obj.values.push([prop, value]);
+      obj.values.push([prop, `$${prop}$`, value]);
     } else {
-      obj.values[index] = [prop, value];
+      obj.values[index] = [prop, `$${prop}$`, value];
     }
     return true;
   },
@@ -96,17 +102,30 @@ function createModulesReducer() {
       }
       default: {
         let nextState = null;
-        for (const [name, reducer] of modulesReducers) {
+        for (const [name, prefix, reducer] of modulesReducers) {
+          let copy = undefined;
+
+          if (action.type.startsWith(BROADCAST_ACTION_PREFIX)) {
+            copy = action;
+          } else if (action.type.startsWith(prefix)) {
+            copy = {
+              ...action,
+              type: action.type.replace(prefix, ""),
+            };
+          } else {
+            copy = PROBE_ACTION;
+          }
+
           try {
-            const fragment = reducer(state[name], action);
+            const fragment = reducer(state[name], copy);
             if (state[name] !== fragment) {
               if (!nextState) {
                 nextState = { ...state };
               }
               nextState[name] = fragment;
             }
           } catch (error) {
-            warning(`module ${name} reducer failed to reduce on action ${action.type}`, error);
+            warning(`module ${name} reducer failed to reduce`, error);
           }
         }
         if (nextState) {

platform/src/kernel/registry/__tests__/store.test.js

@@ -217,9 +217,9 @@ describe("store registry", () => {
         const store = getStore().namespace("my-feature");
 
         expect(typeof store.dispatch).toEqual("function");
-        store.dispatch({ type: "foo" });
 
-        expect(storeRef.getActions()).toEqual([{ type: "foo" }]);
+        store.dispatch({ type: "foo" });
+        expect(storeRef.getActions()).toEqual([{ type: "$my-feature$foo" }]);
         storeRef.clearActions();
 
         store.dispatch({
@@ -228,7 +228,6 @@ describe("store registry", () => {
             data: "secret",
           },
         });
-
         expect(storeRef.getActions()).toEqual([
           {
             type: SET_SHARED,
@@ -238,6 +237,35 @@ describe("store registry", () => {
             },
           },
         ]);
+        storeRef.clearActions();
+
+        store.dispatch({
+          type: "@@BROADCAST",
+          payload: {
+            data: "chatter",
+          },
+        });
+        expect(storeRef.getActions()).toEqual([
+          {
+            type: "@@BROADCAST",
+            payload: {
+              data: "chatter",
+            },
+          },
+        ]);
+        storeRef.clearActions();
+
+        store.dispatch({
+          type: undefined,
+        });
+        expect(storeRef.getActions()).toEqual([]);
+        storeRef.clearActions();
+
+        store.dispatch({
+          type: "$injection$ACTION",
+        });
+        expect(storeRef.getActions()).toEqual([]);
+        storeRef.clearActions();
       });
 
       it(".subscribe", () => {

platform/src/kernel/registry/store.js

@@ -1,6 +1,8 @@
 import { SET_SHARED } from "../../constants";
 import { warning } from "../../utils";
 
+const BROADCAST_ACTION_PREFIX = "@@";
+
 const nilStore = {
   dispatch() {
     warning("Redux store is not provided!");
@@ -28,6 +30,9 @@ const handler = {
     let stateProxy = null;
     return (name) => ({
       dispatch: (action) => {
+        if (!action.type || action.type[0] === "$") {
+          return;
+        }
         if (action.type === SET_SHARED) {
           return store.dispatch({
             type: SET_SHARED,
@@ -37,7 +42,13 @@ const handler = {
             },
           });
         }
-        return store.dispatch(action);
+        if (action.type.startsWith(BROADCAST_ACTION_PREFIX)) {
+          return store.dispatch(action);
+        }
+        return store.dispatch({
+          ...action,
+          type: `$${name}$${action.type}`,
+        });
       },
       getState() {
         const state = store.getState();