Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some tips of query builder #3733

Open
chanmaoganda opened this issue Feb 10, 2025 · 0 comments · May be fixed by #3734
Open

Add some tips of query builder #3733

chanmaoganda opened this issue Feb 10, 2025 · 0 comments · May be fixed by #3734
Labels
enhancement New feature or request

Comments

@chanmaoganda
Copy link

I have found these related issues/pull requests

If we try to build with builder.push_values, and we pass an empty list, the sql query will fails, cause nothing is generated via an empty list.
Perhaps this should be mentioned in the docs

Description

builder.push_values

Prefered solution

add some docs for QueryBuilder

Is this a breaking change? Why or why not?

not a breaking change, just a small tip
@chanmaoganda chanmaoganda added the enhancement New feature or request label Feb 10, 2025
@chanmaoganda chanmaoganda linked a pull request Feb 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

QueryBuilder: warn when push_values is passed an empty set of tuples chanmaoganda/sqlx
1 participant
@chanmaoganda