Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Unhandled exception from ldapJS while LDAP filter strings length exceeds #803

Closed
ujjwalchk-it opened this issue May 16, 2022 · 2 comments
Closed

Comments

@ujjwalchk-it
Copy link

We are getting this exception from ldapJS when the LDAP filter string length exceeds the configured filter string size limit at LDAP end.
Observation - Unhandled exception from ldapJS (mentioned below)
Expectation - The error should be caught gracefully under res.on('error', (err) => {...})

Unhandled exception -

/Users/ujjwalchakraborty/Desktop/node_modules/ldapjs/lib/errors/index.js:98
  const E = module.exports[errObj.err]
                                  ^

TypeError: Cannot read properties of undefined (reading 'err')
    at Object.module.exports.getError (/Users/ujjwalchakraborty/Desktop/node_modules/ldapjs/lib/errors/index.js:98:35)
    at messageCallback (/Users/ujjwalchakraborty/Desktop/node_modules/ldapjs/lib/client/client.js:1220:45)
    at Parser.onMessage (/Users/ujjwalchakraborty/Desktop/node_modules/ldapjs/lib/client/client.js:888:14)
    at Parser.emit (node:events:520:28)
    at Parser.write (/Users/ujjwalchakraborty/Desktop/node_modules/ldapjs/lib/messages/parser.js:107:8)
    at Socket.onData (/Users/ujjwalchakraborty/Desktop/node_modules/ldapjs/lib/client/client.js:875:22)
    at Socket.emit (node:events:520:28)
    at addChunk (node:internal/streams/readable:315:12)
    at readableAddChunk (node:internal/streams/readable:289:9)
    at Socket.Readable.push (node:internal/streams/readable:228:10)

Appreciate any advise on this .

@jsumners
Copy link
Member

Would you like to send a Pull Request to address this issue? Remember to add unit tests. An integration test would also be very welcome.

@jsumners
Copy link
Member

👋

On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request.

Please see issue #839 for more information, including how to proceed if you feel this closure is in error.

@ldapjs ldapjs locked as resolved and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants