-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove theme-dependent SCSS variables: Remove variables within KDS files that rely on theming SCSS variables #617
Comments
Related comment addressing this issue: #616 (comment) |
@nucleogenesis @LianaHarris360 I would like to work on this issue. Could you please assign me this issue? |
Sure, I can assign you @shruti862. To resolve this issue, in Wherever those SCSS variables are used in KDS components or styles, replace them with the corresponding JS/Vue theme variables. For example, In So we'd need to remove the css:
and use the theme variable directly in the Vue template:
or set it with dynamic class binding if necessary. Because we can’t rely on CSS variables for Vue.js CSS binding across all supported browsers, Vue’s inline style binding or dynamic classes referencing the If you have any other questions, or need more clarification, just let us know! |
@LianaHarris360 Thank you for assigning me the issue. I understood whats needs to be done thank you for explaining so well. |
Hey @LianaHarris360 , I wanted to ask whether i needed to remove Also Can you please review my PR to see whether i am going in right direction or not . |
@shruti862 It seems that |
Product
Kolibri-design-system:
Internal
Current behavior
In the file
lib/keen/styles/variables.scss
, defined variables rely other theming variables and should be removed.For example:
(Optional) The Value Add
Theme-dependent SCSS variables have the potential to break our theming. Overall, this may only pose a concern within our vendored Keen components that are integrated with KDS.
This could potentially be part of a larger initiative to fully integrate or remove our vendored Keen components altogether.
The text was updated successfully, but these errors were encountered: