Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared view-only channel - A user cannot delete a view-only channel #4760

Open
pcenov opened this issue Sep 26, 2024 · 4 comments
Open

Shared view-only channel - A user cannot delete a view-only channel #4760

pcenov opened this issue Sep 26, 2024 · 4 comments
Assignees
Labels
P2 - normal Priority: Nice to have

Comments

@pcenov
Copy link
Member

pcenov commented Sep 26, 2024

Observed behavior

If someone has shared a channel with me as 'View-only' when I attempt to deleted it at the 'View-only' page I see an error in the console and when I refresh the page, the channel reappears again. This is not a recent regression as it's present at the live site as well.

Expected behavior

To be further discussed. Perhaps this option should be called 'Remove channel' instead and it should just remove the channel from the

Steps to reproduce the issue

  1. Go to https://unstable.studio.learningequality.org/en/accounts/#/ and sign in as user A
  2. Open a channel and select the 'Share channel' option
  3. Share the channel with user B by selecting the 'Can view' option
  4. Sign in as user B and accept the invitation
  5. While at the 'View-only' page attempt to delete the channel

Additional information

delete.view-only.channel.mp4

Usage Details

@akolson
Copy link
Member

akolson commented Sep 26, 2024

This might be a safeguard to prevent the deletion of view-only content, though I'm not entirely sure. In such a case, wouldn't it be more logical to simply hide the delete option? @rtibbles @bjester, is there any background behind this issue that you could provide?

@rtibbles
Copy link
Member

Yes, I think we just shouldn't be showing the button - although it would be useful to have an option to no longer be a viewer on a channel.

@akolson akolson added P3 - low Priority: Stretch goal P2 - normal Priority: Nice to have and removed P2 - normal Priority: Nice to have P3 - low Priority: Stretch goal labels Sep 26, 2024
@FidalMathew
Copy link
Contributor

@rtibbles Can I work on this issue?

@AllanOXDi
Copy link
Member

AllanOXDi commented Nov 11, 2024

Hi @FidalMathew , Yes you can! I have assigned it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

5 participants