Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/document Leopard source code as TypeScript #131

Closed
towerofnix opened this issue Jul 18, 2022 · 2 comments · Fixed by #146
Closed

Refactor/document Leopard source code as TypeScript #131

towerofnix opened this issue Jul 18, 2022 · 2 comments · Fixed by #146

Comments

@towerofnix
Copy link
Member

See a recent comment: #119 (comment)

Incorrect method name. Errors when using this.touching("edge") while a speech bubble is active.

(I got very lucky! My test project happened to include this case. We could consider using Typescript to avoid these kinds of errors and also to provide type hints for people using Leopard.)

See also discussion in #128—since we're already working with a build step, it wouldn't add any new steps to the current development workflow.

Bonus reason for writing Leopard in TypeScript: sb-edit uses TypeScript, and it's good to be consistent across the two connected codebases!
@towerofnix towerofnix mentioned this issue Jul 18, 2022
Merged
@PullJosh
Copy link
Collaborator

I am in favor of this if others are.

@towerofnix
Copy link
Member Author

All in favor, react 👍 :)

@adroitwhiz adroitwhiz mentioned this issue Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert project to TypeScript adroitwhiz/leopard
2 participants
@PullJosh @towerofnix