Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handling for SQRT, LN, and LOG Functions #2977

Open
younes199511 opened this issue Jul 2, 2024 · 2 comments
Open

Error Handling for SQRT, LN, and LOG Functions #2977

younes199511 opened this issue Jul 2, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@younes199511
Copy link

Environment:

  • eKuiper version: 1.12.8

What happened and what you expected to happen:
The SQRT, LN, and LOG functions currently do not return an error when the argument is a negative value, unlike other undefined states where an error is returned, such as division by zero. It would greatly improve the user experience if an error was returned in such cases, as it would clearly indicate when an execution of a rule has failed due to an unaccepted argument. This enhancement would benefit users by providing clearer feedback on invalid inputs

How to reproduce it (as minimally and precisely as possible):
Try to execute a rule with sqrt(-1) or log(-1)

@Yisaer
Copy link
Collaborator

Yisaer commented Jul 3, 2024

Thanks for reporting

@Yisaer Yisaer added the good first issue Good for newcomers label Jul 3, 2024
@AritroSaha10
Copy link

Hi, I can work on this, I'll reply later with a PR reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants