Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity period query won't pick up activity close to 0/360 #52

Open
lfborjas opened this issue Dec 28, 2020 · 0 comments
Open

Activity period query won't pick up activity close to 0/360 #52

lfborjas opened this issue Dec 28, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@lfborjas
Copy link
Owner

If a position is between 359 and 360, or between 0 and 1; the current period of activity query will truncate the examined orb to 360 or 0, rendering one side of the activity shorter than it should. This is merely due to the query needing to be a bit more complicated to account for "choppy" intervals (e.g. between 359.5 and 360 ... UNION ... between 0 and 0.5). With the improved angle calculations in #46, we can now derive these intervals and just need to translated to (somewhat unwieldy) SQL -- write tests!

@lfborjas lfborjas added the bug Something isn't working label Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant