Renaming symbols is incorrect

[certik]

program expr2
implicit none

integer :: program

program = (2+3)*5
print *, program

end program

When you select the program variable, it will rename all occurrences of the term program, not just the variable. We must use LFortran's ASR to find the local variable "program" and only rename that.

[dylon]

We are blocked on fixing this until lfortran/lfortran#5558 is resolved. At the moment, lfortran misses some symbol locations so we perform a global replacement.

[certik]

This still does not work. It seems to be doing a global replacement.

There are two issues that I can see:

• silencing an LFortran failure (if that is the case --- not sure)
• doing global replacement, which I do not want

To fix this, let's add a settings option that will disable any silent failover; I will then enable this and then I want to see a clear error in the logs every time something fails. Then we can report all bugs and fix it.

I made this #33.

[Pranavchiku]

Yes, I can reproduce this:

on Rename

renamed variable

[certik]

It seems to work now:

So I am going to close it.