Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose histogram metric type #2677

Closed
wemeetagain opened this issue Sep 3, 2024 · 0 comments · Fixed by #2705
Closed

Expose histogram metric type #2677

wemeetagain opened this issue Sep 3, 2024 · 0 comments · Fixed by #2705
Labels
need/triage Needs initial labeling and prioritization

Comments

@wemeetagain
Copy link
Member

Current metrics interface and implementation expose Metric, MetricGroup, Counter and CounterGroup.

But there's no Histogram!

Histograms (or summaries) are essential for capturing data that measures timing and the distributions of observations.
See https://prometheus.io/docs/practices/histograms/

Answers questions like:

  • How long does it usually take to negotiate a handshake?
  • What's the distribution of # of streams per connection?
  • What's the distribution of RTTs on all active connections?
@wemeetagain wemeetagain added the need/triage Needs initial labeling and prioritization label Sep 3, 2024
@SgtPooki SgtPooki linked a pull request Sep 18, 2024 that will close this issue
feat: add histogram and summary metric types #2705
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add histogram and summary metric types libp2p/js-libp2p
1 participant
@wemeetagain