Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-sound channel individual volume core options (WIP, help needed) #166

Open
eadmaster opened this issue Nov 24, 2020 · 3 comments
Open

Comments

@eadmaster
Copy link
Contributor

eadmaster commented Nov 24, 2020

This is meant to "fix" games having unbalanced SFX vs the BGM.

I've found the PSG::accumulateChannels() in sound.cpp may be the method to change, if you haven't better suggestions i'll try this myself.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

eadmaster pushed a commit to eadmaster/gambatte-libretro that referenced this issue Nov 24, 2020
@eadmaster
Copy link
Contributor Author

UPDATE: it seems to work somehow, btw i need to figure out the correct scaling factor for the volume.
If you have any suggestion please post here.

@eadmaster eadmaster changed the title per-sound channel individual volume core options Per-sound channel individual volume core options Nov 24, 2020
@eadmaster
Copy link
Contributor Author

eadmaster commented Nov 25, 2020

I think i've figured out how to mute and max the volume correctly.
I've just submitted the PR, please review:
#167

eadmaster pushed a commit to eadmaster/gambatte-libretro that referenced this issue Nov 27, 2020
eadmaster pushed a commit to eadmaster/gambatte-libretro that referenced this issue Nov 27, 2020
fixes for max and 0 volumes

reworked accumulateChannels to preserve volume effects

minor fixes

reverted soChVol_ to long
eadmaster pushed a commit to eadmaster/gambatte-libretro that referenced this issue Nov 27, 2020
fixes for max and 0 volumes

reworked accumulateChannels to preserve volume effects

minor fixes

reverted soChVol_ to long
eadmaster pushed a commit to eadmaster/gambatte-libretro that referenced this issue Nov 29, 2020
fixes for max and 0 volumes

reworked accumulateChannels to preserve volume effects

minor fixes

reverted soChVol_ to long
inactive123 added a commit that referenced this issue Dec 2, 2020
added per-sound channel individual volume core options (#166)
@cmitu cmitu mentioned this issue Dec 21, 2020
inactive123 added a commit that referenced this issue Dec 24, 2020
Revert "added per-sound channel individual volume core options (#166)"
@eadmaster eadmaster reopened this Dec 24, 2020
@eadmaster eadmaster changed the title Per-sound channel individual volume core options Per-sound channel individual volume core options (WIP) Dec 24, 2020
@eadmaster eadmaster changed the title Per-sound channel individual volume core options (WIP) Per-sound channel individual volume core options (WIP, help needed) Dec 26, 2020
@eadmaster
Copy link
Contributor Author

UPDATE: the issue with 32bit systems should be fixed now in my fork, but the volume scaling is still not working as expected as reported here by bslenul. If you can help me with this please post here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant