Replace op->erase() with rewriter.eraseOp

[rengolin]

Ref: https://mlir.llvm.org/docs/PatternRewriter/#pattern-rewriter

[arun-thmn]

@rengolin Ah okay. Thanks.
Is this option introduced newly to MLIR, or it does exists already and I missed it?

[rengolin]

Is this option introduced newly to MLIR, or it does exists already and I missed it?

It's old, but easy to miss, because both ways are exposed but you only know you're not supposed to use the other one by reading a document. Not great API design. :)