Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a docker image on dockerhub #175

Open
raweber42 opened this issue Nov 16, 2023 · 4 comments · May be fixed by #187
Open

Provide a docker image on dockerhub #175

raweber42 opened this issue Nov 16, 2023 · 4 comments · May be fixed by #187

Comments

@raweber42
Copy link

Is your feature request related to a problem? Please describe.
For using the Docker Image, it would be way easier to be able to just pull the image from dockerhub (or any alternative).

Describe the solution you'd like
A Docker Image is automatically created (maybe through GitHub Actions?) and pushed to a openly available registry. The Documentation is adjusted accordingly.

Describe alternatives you've considered
Let all users build the Docker images themselves.

Additional context
Especially useful for a kubernetes setup!

@NonsoAmadi10
Copy link

@guggero do you think this feature is what faraday needs at this time? I don't mind picking this up

@guggero
Copy link
Member

guggero commented Feb 22, 2024

Sure, that would be useful. Should be pretty straightforward, just need to copy and adjust https://github.com/lightninglabs/loop/blob/master/.github/workflows/docker.yml

@NonsoAmadi10
Copy link

NonsoAmadi10 commented Feb 22, 2024

awesome! I will be picking this up. Thanks! One small question:

Is the docker hub lightninglabs/faraday? @guggero

@guggero
Copy link
Member

guggero commented Feb 22, 2024

Is the docker hub lightninglabs/faraday?

Yes. I mean it doesn't exist yet (the first push will create it), but that's the repo name we'd want to use.
And it will only work after we've added the required credentials as GitHub repository secrets, which the repo admin will have to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants