Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fiat: Expand fiat backends #37

Open
carlaKC opened this issue May 27, 2020 · 2 comments
Open

fiat: Expand fiat backends #37

carlaKC opened this issue May 27, 2020 · 2 comments
Labels
fiat related to fiat conversion package

Comments

@carlaKC
Copy link
Contributor

carlaKC commented May 27, 2020

As is, the fiat package only uses CoinCap's API for price information. The package is designed to allow different price sources without affecting our price calculation logic.

Steps to completion

  1. Identify different sources of price data and propose in this issue (perhaps coindesk)
  2. Add code to obtain price data over a range and update fiat/GetPrices to allow users to choose a backend
  3. Update rpc to allow choice of backends
@carlaKC carlaKC added fiat related to fiat conversion package and removed accounting labels May 27, 2020
@nixbitcoin
Copy link

nixbitcoin commented Aug 10, 2020

It would also be great to create a Proxy option, like --server.proxy in loopd, to tunnel all price requests over Tor. This has obvious privacy benefits.

@zkSNACKs offer a Tor v3 HS under which you can request prices at http://wasabiukrxmkdgve5kynjztuovbg43uxcbcxn6y2okcrsg7gb6jdmbad.onion/api/v3/btc/Offchain/exchange-rates.

@ellemouton
Copy link
Member

I was having a go at adding the --server.proxy option that @nixbitcoin suggested. However, it seems to me that CoinCap does not allow requests over Tor. When I curl the API directly I get json back but when I curl the API through the Tor proxy then I get a webpage back that requires a captcha to be completed. The same does not go for other APIs such as coindesk which makes me think that CoinCap is not allowing Tor requests (i am a Tor noob though so there may be a way to get around this that I am unaware of).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fiat related to fiat conversion package
Projects
None yet
Development

No branches or pull requests

3 participants