Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]: Expiry AMP invoice even though they have settled sub invoices. #9463

Open
ziggie1984 opened this issue Jan 30, 2025 · 1 comment
Open

[feature]: Expiry AMP invoice even though they have settled sub invoices. #9463

ziggie1984 opened this issue Jan 30, 2025 · 1 comment
Labels
amp enhancement Improvements to existing features / behaviour invoices

Comments

@ziggie1984
Copy link
Collaborator

Currently we do not expiry recurring AMP invoice when they have at least one settled sub invoice. However that means that any AMP invoice with this conditions stays OPEN forever and can therefore accept payments forever. This might not be practical for bookkeeping reasons if we cannot rely on a final state of an invoice. Hence we should nonetheless expiry the invoice and move it into a state which will not accept more payments.
@ziggie1984 ziggie1984 added amp enhancement Improvements to existing features / behaviour invoices labels Jan 30, 2025
@ziggie1984 ziggie1984 mentioned this issue Jan 30, 2025
Merged
@ziggie1984
Copy link
Collaborator Author

What should done here as well is to refactor the whole setID AMP HTLC invoice fetching.

see also: #9459 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
amp enhancement Improvements to existing features / behaviour invoices
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ziggie1984