[itest]: missing itest for funding timeout case of 2016 blocks

[Crypt-iQ]

Noticed this when looking through the code. We should be able to modify this constant

lnd/funding/manager.go

Lines 104 to 107 in 693b399

	// MaxWaitNumBlocksFundingConf is the maximum number of blocks to wait
	// for the funding transaction to be confirmed before forgetting
	// channels that aren't initiated by us. 2016 blocks is ~2 weeks.
	MaxWaitNumBlocksFundingConf = 2016

in the itests so that we can mine very few blocks and trigger the timeout case.

[morehouse]

I worked an an itest for this a few years ago: #7228

That work got stalled waiting on #7241, and I never picked it up again.

[yyforyongyu]

Yeah would be nice to revive #7228, plus I don't think we need to mine that many blocks in the itest, this value can be changed using a build tag such that for integration this can be set to a much smaller value.

[Rakshitsinghhh]

Yeah would be nice to revive #7228, plus I don't think we need to mine that many blocks in the itest, this value can be changed using a build tag such that for integration this can be set to a much smaller value.

That makes sense! I was thinking of using a build tag to override MaxWaitNumBlocksFundingConf for integration tests, reducing it to a much lower value so we don’t have to mine too many blocks while still triggering the timeout case. Would this approach be a good way to minimize block mining?

[guggero]

You can make it a configurable value, but expose the flag to actually configure it only in dev/integration test builds by adding it here:

lnd/lncfg/dev_integration.go

Line 23 in ab7aae0

type DevConfig struct {

[Rakshitsinghhh]

You can make it a configurable value, but expose the flag to actually configure it only in dev/integration test builds by adding it here:

lnd/lncfg/dev_integration.go

Line 23 in ab7aae0

type DevConfig struct {

Is this what you meant—making MaxWaitNumBlocksFundingConf configurable in DevConfig and exposing a flag only for dev/integration builds while keeping 2016 as the default for production?

[NishantBansal2003]

Could I be assigned to this issue if it's available to work on?