Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit testing of ambry-server, ambry-store and ambry-replication. #301

Open
vgkholla opened this issue May 13, 2016 · 2 comments
Open
Labels

Comments

@vgkholla
Copy link
Contributor

Currently, much of the code in ambry-server, ambry-store and amby-replication is being tested via integration tests in ambry-server. Unit testing coverage has to be improved in these packages so that failures are caught faster, bugs are easy to isolate and debugging is easier.

Doing this will require understanding of each of these components. A starting point would be running the unit tests in each of these packages, checking the coverage, understanding the classes that need more coverage and writing appropriate tests. Aim to cover all lines as well as cases.

@sriramsub
Copy link
Contributor

I don't get what needs to be improved from the description. Without very clear definition of what unit test needs to be written, I don't see this to be a newbie issue.

@vgkholla
Copy link
Contributor Author

What needs to be improved is unit test coverage since most of the code in these packages is being tested via integration tests and not unit tests.

This is a high level ticket to investigate what unit tests need to be written and write them. My thought process is that it would encourage a newbie to read the code and at the same time contribute something useful. We can always create individual issues for particular tests.

I can remove the newbie tag if you think we need to create individual issues that can be tagged newbie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants