Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how we handle IOExceptions in Transmission implementation #324

Open
nsivabalan opened this issue May 21, 2016 · 0 comments
Open

Fix how we handle IOExceptions in Transmission implementation #324

nsivabalan opened this issue May 21, 2016 · 0 comments

Comments

@nsivabalan
Copy link
Contributor

close() in Transmission throws IOException, whereas both the implementation (plaintext and ssl) doesn't throw them. This patch is to revisit them and ensure they do throw IOExceptions instead of catching them. Caller might have do something about it and let not the transmission suppress them.
@nsivabalan nsivabalan mentioned this issue May 21, 2016
Merged
@pnarayanan pnarayanan changed the title Fix how we handle IOExcpetions in Transmission implementation Fix how we handle IOExceptions in Transmission implementation May 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nsivabalan