Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all NetworkMetrics are registered #334

Open
pnarayanan opened this issue May 26, 2016 · 2 comments
Open

Ensure all NetworkMetrics are registered #334

pnarayanan opened this issue May 26, 2016 · 2 comments
Labels
newbie

Comments

@pnarayanan
Copy link
Contributor

selectorActiveConnections for one, is never registered. Might as well look at the rest of the metrics in NetworkMetrics.
@vgkholla
Copy link
Contributor

This is now called numActiveConnections

@vgkholla
Copy link
Contributor

There are also unused functions in the class (easy to see with an IDE). Please remove them as well.

@pnarayanan pnarayanan mentioned this issue Jun 8, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
newbie
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vgkholla @pnarayanan