Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of ByteBufferPool #396

Open
vgkholla opened this issue Jul 13, 2016 · 1 comment
Open

Use of ByteBufferPool #396

vgkholla opened this issue Jul 13, 2016 · 1 comment
Assignees

Comments

@vgkholla
Copy link
Contributor

Creating this issue to start an initial discussion on and list places where the ByteBufferPool can be used. Some of the tasks will require issues of their own.

P.1) Improve the current implementation of ByteBufferPool (SimpleByteBufferPool) or create a new implementation that actually pools buffers. This will require design documentation and discussions.
P.2) Use the ByteBufferPool (this is independent of P.1) in the NonBlockingRouter while filling chunks and also in BoundedByteBufferReceive. Using it in BoundedByteBufferReceive might require a bit of effort but it has to be done for pooling to be correct and effective since GETs are expected to be a large chunk of traffic in any use-case involving Ambry.

@haggag
Copy link

haggag commented Mar 19, 2017

Consider using Netty's ByteBuf and its jemalloc implemention to support buffer pooling. https://netty.io/4.1/api/io/netty/buffer/ByteBuf.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants