Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove appendFrom(ByteBuffer) method in the Write interface #476

Open
vgkholla opened this issue Oct 28, 2016 · 0 comments
Open

Remove appendFrom(ByteBuffer) method in the Write interface #476

vgkholla opened this issue Oct 28, 2016 · 0 comments

Comments

@vgkholla
Copy link
Contributor

It is used only in tests and tests can easily use the method that takes in a channel. This avoids duplicated code in the implementations (also there isn't a production use case for this function).

Remove the functions from the implementations also.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vgkholla