Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements / Bug: update checkbox state in header, when check / uncheck checkboxes in data rows #116

Open
dhsmedia opened this issue Aug 8, 2024 · 0 comments

Comments

@dhsmedia
Copy link

dhsmedia commented Aug 8, 2024

Improvements:

1st improvement:
The checkbox in header will not be unchecked when one checkbox in a data row will be unchecked.
When checking all checkboxes of all data rows manually, the checkbox will be checked automatically. The other way round, the checkbox in header should be unchecked, when not all checkboxes in the data rows are checked.

Steps to reproduce:

  1. Set has-checkbox = true
  2. Display table with i.e. 5 data rows
  3. Check the checkbox in header > All 5 checkboxes of the data rows will be checked.
  4. Uncheck any checkbox of a data row > The checkbox in header will not be unchecked

2nd improvement:
Replace the div element, that is surrounding the checkbox with a label for element. This gives the developer of the web app the ability to add some padding around the checkbox, so that the user doesn't have to click exactly onto the checkbox to check / uncheck it.

Bug

The function clearChecked() does not uncheck the checkbox in header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant