Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Upgrade to Version 3 (again) #55

Closed
1 task done
vonguard opened this issue Sep 15, 2024 · 9 comments
Closed
1 task done

[FEAT] Upgrade to Version 3 (again) #55

vonguard opened this issue Sep 15, 2024 · 9 comments

Comments

@vonguard
Copy link

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Upgrade to Version 3 of Ubooquity, despite it only being a beta. It has been almost 12 months since the beta release. Nothing more is coming any time soon and it's a major upgrade.

Reason for change

Stability, speed, reliability, better overall experience, and again, there seems not to be a stable release coming any time soon. This beta is it. I know you marked this as closed previously, but it's been 10 months since that closure.

Proposed code change

No response

Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@aptalca
Copy link
Member

aptalca commented Sep 15, 2024

#47 (comment)

@logicwar
Copy link

It would be good to have a 2nd and separate docker image for 3.0 (it shouldn't replace 2.1.4). As mentionned above 3.0.2 is almost a year old now.

@vonguard
Copy link
Author

vonguard commented Sep 17, 2024

And now there is a vulnerability in the 2.x branch. Developer is advising all users to update to 2.1.4 or to 3. 3 is a breaking release, also, and requires a complete re scrape of the DB. Advise bumping this to version 2.1.4, then starting a new container project for 3. https://vaemendis.net/ubooquity/article24/vulnerabilty-in-ubooquity-2-1-2-please-update-to-2-1-4-ubooquity-3-is-safe I see an update in the pipe so maybe you already did the 2.1.4 update? If so, hats off to y'all being on top of things!

@thespad
Copy link
Member

thespad commented Sep 17, 2024

If it's a breaking change to v3 and from what I've read there's no plan to change that, we can't just update latest to v3 because it would break everyone's containers. And we can't do a v3 tag and then switch it, because everyone will keep unknowingly downloading v2.

Equally starting a whole new repo just for v3 feels like the wrong thing to do, so I'm not sure what the best approach is.

@vonguard
Copy link
Author

Definitely a sticky issue, but tags can help with this: https://www.geeksforgeeks.org/docker-versioning-best-practices/

@thespad
Copy link
Member

thespad commented Oct 14, 2024

Just taken a look again and this still isn't workable because the beta download endpoint doesn't work - https://vaemendis.net/ubooquity/service/download-beta.php

It tries to return a 3.0.1.zip which doesn't exist because 3.0.2 has been released since and the old zip removed.

I'm not going to play games hunting download URLs, it's never worth the effort.

We'll have to revisit this once v3 is actually the stable release and/or the download endpoint is being properly updated.

@thespad thespad closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Oct 14, 2024
@deepdivered
Copy link

Here is the link to the 3.0.2 file which is not located in the beta folder anymore.

https://vaemendis.net/ubooquity/downloads/Ubooquity-3.0.2.zip

@thespad
Copy link
Member

thespad commented Dec 23, 2024

The problem isn't the download link, it's that there's no reliable endpoint to query the current version from. At the moment we query vaemendis.net/ubooquity/service/download.php and see what file it tries to return (which is still 2.1.5), but there's no automated way for us to know what the current v3 release version is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants