Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample values in Chart activity are not initialized #1695

Open
llaske opened this issue Dec 30, 2024 · 4 comments
Open

Sample values in Chart activity are not initialized #1695

llaske opened this issue Dec 30, 2024 · 4 comments
Labels
bug to be release Fixed, to be release

Comments

@llaske
Copy link
Owner

llaske commented Dec 30, 2024

At first launch, the Chart activity use sports name to initialize values.
When launch from the app in a default English language, values are not initialized (EgLabelX).

image

Full step to reproduce:

Capture.video.du.2024-12-30.18-02-31.webm
@llaske llaske added the bug label Dec 30, 2024
@SaniyaBorkar
Copy link

SaniyaBorkar commented Dec 31, 2024 •
edited
Loading

@AdityaKrSingh26 have you tried this loader implementation? If yes, can you just test does it work in firefox? I tried a delay but it isn't working with firefox. If you got the same issue with firefox ig this implementation wouldn't work or it could be that this is limited to Firefox when Sugarizer is used from local directory (file:///).

@kumar-piyush12
Copy link

Hi @llaske, I have fixed this issue. I am new in Open Source Contribution. I humbly request you to accept my Pull Request.
Thank you
1

@kumar-piyush12 kumar-piyush12 mentioned this issue Jan 2, 2025
Closed
SaniyaBorkar added a commit to SaniyaBorkar/sugarizer that referenced this issue Jan 12, 2025
@SaniyaBorkar
Resolved issue llaske#1695: Initialized sample values in Chart activity
ecd4c92
@SaniyaBorkar SaniyaBorkar mentioned this issue Jan 12, 2025
Merged
@SaniyaBorkar
Copy link

SaniyaBorkar commented Jan 12, 2025 •
edited
Loading

@llaske Please have a look at my pr

@llaske
Copy link
Owner Author

llaske commented Jan 15, 2025

Fixed in #1703

@llaske llaske added the to be release Fixed, to be release label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug to be release Fixed, to be release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@llaske @SaniyaBorkar @kumar-piyush12