From d64f177a2f4ae91cf520111dffed73f3c6b555eb Mon Sep 17 00:00:00 2001 From: Christian Sigg Date: Tue, 18 Feb 2025 12:59:15 +0100 Subject: [PATCH] [mlir][bazel] Fix `no-allow-shlib-undefined` errors. The BUILD file changes in https://github.com/llvm/llvm-project/pull/127544 adds `LinalgInterfaces` which is incomplete without `LinalgDialect`. For now, just add the `LinalgDialect` as dependency to tests which do not otherwise depend on it (but depend on `LinalgInterfaces` through e.g. `TensorDialect`). This is a temporary solution until the dependency of `TensorDialect` is trimmed to just the `linalg::RelayoutOpInterface`, but not the other linalg interfaces. See https://github.com/llvm/llvm-project/pull/127544#pullrequestreview-2622065243. --- utils/bazel/llvm-project-overlay/mlir/unittests/BUILD.bazel | 2 ++ 1 file changed, 2 insertions(+) diff --git a/utils/bazel/llvm-project-overlay/mlir/unittests/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/unittests/BUILD.bazel index a55c6f50118dc..d0c9f56f81cb9 100644 --- a/utils/bazel/llvm-project-overlay/mlir/unittests/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/mlir/unittests/BUILD.bazel @@ -176,6 +176,7 @@ cc_test( "//mlir:ArithDialect", "//mlir:FuncDialect", "//mlir:IR", + "//mlir:LinalgDialect", "//mlir:Parser", "//mlir:SCFDialect", "//mlir:SideEffectInterfaces", @@ -211,6 +212,7 @@ cc_test( "//llvm:Support", "//llvm:TestingSupport", "//mlir:IR", + "//mlir:LinalgDialect", "//mlir:SPIRVBinaryUtils", "//mlir:SPIRVDeserialization", "//mlir:SPIRVDialect",