From d5492cfe0a52512b981a452dea2a373d640e1416 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 12 Feb 2025 19:23:16 -0800 Subject: [PATCH 1/3] DeveloperPolicy: Update commit access requirements See https://discourse.llvm.org/t/rfc-commit-access-criteria/84073 --- llvm/docs/DeveloperPolicy.rst | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst index b125fcb0da7ab..cc428d3c6bc0e 100644 --- a/llvm/docs/DeveloperPolicy.rst +++ b/llvm/docs/DeveloperPolicy.rst @@ -539,11 +539,13 @@ What are the expectations around a revert? Obtaining Commit Access ----------------------- -We grant commit access to contributors that can provide a valid justification. -If you would like commit access, please use this `link `_ to file +Once you have 3 or more merged pull requests, you may use this +link `_ to file an issue and request commit access. Replace the string in the title with your github username, and explain why you are requesting commit access in -the issue description. If approved, a GitHub invitation will be sent to your +the issue description. Once the issue is created, you will need to get two +current contributors to ack your requests before commit access will be granted. +If approved, a GitHub invitation will be sent to your GitHub account. In case you don't get notification from GitHub, go to `Invitation Link `_ directly. Once you accept the invitation, you'll get commit access. From b610f2123cf1314c19324e4e49f536d9b56db7a3 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Fri, 14 Feb 2025 17:13:42 -0800 Subject: [PATCH 2/3] Update DeveloperPolicy.rst --- llvm/docs/DeveloperPolicy.rst | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst index cc428d3c6bc0e..b335d8c0d8104 100644 --- a/llvm/docs/DeveloperPolicy.rst +++ b/llvm/docs/DeveloperPolicy.rst @@ -544,7 +544,15 @@ link string in the title with your github username, and explain why you are requesting commit access in the issue description. Once the issue is created, you will need to get two -current contributors to ack your requests before commit access will be granted. +current contributors to support your requests before commit access will be granted. + +Reviewers of your committed patches will automatically be CCed upon creating the issue. +Most commonly these reviewers will provide the necessary approval, but approvals +from other LLVM committers are also acceptable. Those reviewing the application are +confirming that you have indeed had three patches committed, and that based on interactions +on those reviews and elsewhere in the LLVM community they have no concern about you +adhering to our Developer Policy and Code of Conduct. + If approved, a GitHub invitation will be sent to your GitHub account. In case you don't get notification from GitHub, go to `Invitation Link `_ directly. Once From 53ebac07a99b79e55ab2e3185b4f57442cfd1380 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Fri, 14 Feb 2025 17:16:01 -0800 Subject: [PATCH 3/3] Fix Typo. --- llvm/docs/DeveloperPolicy.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst index b335d8c0d8104..ead173e921678 100644 --- a/llvm/docs/DeveloperPolicy.rst +++ b/llvm/docs/DeveloperPolicy.rst @@ -544,7 +544,7 @@ link string in the title with your github username, and explain why you are requesting commit access in the issue description. Once the issue is created, you will need to get two -current contributors to support your requests before commit access will be granted. +current contributors to support your request before commit access will be granted. Reviewers of your committed patches will automatically be CCed upon creating the issue. Most commonly these reviewers will provide the necessary approval, but approvals