Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/buildbot/builders/unified_cmakeex.py fails at least since 'hint' was added #235

Closed
asb opened this issue Jul 18, 2024 · 2 comments
Closed

test/buildbot/builders/unified_cmakeex.py fails at least since 'hint' was added #235

asb opened this issue Jul 18, 2024 · 2 comments
Assignees
@vvereschaka

Comments

@asb
Copy link
Contributor

asb commented Jul 18, 2024

I had a quick look at fixing this but I wasn't completely sure what the current partly_rendered logic is trying to achieve.

This is the error, which seems to stem from the format string being passed to util.Interpolate now using syntax that isn't really compatible with Python % based formatting.

Traceback (most recent call last):
  File "/home/asb/repos/llvm-zorg/test/buildbot/builders/unified_cmakeex.py", line 93, in <module>
    assert factory_has_step(f, "Checkout the source code")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/asb/repos/llvm-zorg/test/buildbot/builders/unified_cmakeex.py", line 38, in factory_has_step
    v = partly_rendered(s.kwargs.get("name"))
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/asb/repos/llvm-zorg/test/buildbot/builders/unified_cmakeex.py", line 19, in partly_rendered
    return r.fmtstring % interpolations
           ~~~~~~~~~~~~^~~~~~~~~~~~~~~~
KeyError: 'kw:hint:-'
@vvereschaka
Copy link
Contributor

vvereschaka commented Jul 18, 2024 •
edited
Loading

Thank you @asb ,
I'll update the tests accordingly.

vvereschaka added a commit to vvereschaka/llvm-zorg that referenced this issue Jul 19, 2024
@vvereschaka
Fix failed test/buildbot/builders/unified_cmakeex.py test (issue llvm…
6daf1ab 
…#235).

* updated the step formatting with 'hint' argument (aoid usage of substitutions).
* allowed only 'str' or None for the 'hint' agrument.
* updated 'test/buildbot/builders/unified_cmakeex.py' test for the factory changes accordingly.
@vvereschaka vvereschaka mentioned this issue Jul 19, 2024
Merged
vvereschaka added a commit that referenced this issue Jul 20, 2024
@vvereschaka
Fix failed test/buildbot/builders/unified_cmakeex.py test (issue #235)…
7933dce 
…. (#237)

The changes for UnifiedTreeBuilder.getCmakeExBuildFactory factory and
its test:

* updated the step formatting with 'hint' argument (avoid usage of
substitutions).
* allowed only 'str' or None for the 'hint' argument.
* updated 'test/buildbot/builders/unified_cmakeex.py' test for the
factory changes accordingly.

See #235 for more details.
@vvereschaka
Copy link
Contributor

Fixed by #237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vvereschaka vvereschaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asb @vvereschaka