Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Rewrite "_vacuumIndex" in the way so it doesn't use a recursion technique #31

Open
vladimiry opened this issue Oct 11, 2021 · 2 comments

Comments

@vladimiry
Copy link
Contributor

The recursion technique is not very well scalable so the "Maximum call stack size exceeded"-like error occurs on some datasets.

@localvoid
Copy link
Owner

I agree that it should be fixed, I just haven't touched js for more than a year, so it is unlikely that I'll write code to fix this issue.
Another way to avoid this issue could be to use termFilter that trims suffix. Something like (term) => term.substring(0, 24)

@vladimiry
Copy link
Contributor Author

vladimiry commented Oct 12, 2021

Fair enough. Still would prefer the issue to remain open as maybe someone will make a PR one day. I just disabled the vacuuming call as that should be ok for my use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants