Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when advancing songs multiple times quickly #377

Open
nyanpasu64 opened this issue Sep 21, 2023 · 2 comments
Open

Crash when advancing songs multiple times quickly #377

nyanpasu64 opened this issue Sep 21, 2023 · 2 comments
Assignees

Comments

@nyanpasu64
Copy link

Describe
When I use Command+Left/Right to switch songs many times quickly, Cog crashes.

To Reproduce (delete if not applicable)
Steps to reproduce the behavior:

  1. Download https://forums.serenesforest.net/index.php?/topic/55242-fire-emblem-if-soundtracks-voice-clips-etc/.
  2. Import all songs (or any subfolder) into Cog.
  3. Begin playing a song.
  4. Press Command+Left/Right 2 or more times.

macOS crash report: https://gist.github.com/nyanpasu64/d048522026039e4a8298254e14889a69

Expected behavior
No crash, intermediate song loads are cancelled and final selected song plays.

Screenshots
Screenshot 2023-09-21 at 12 48 48 AM

Version information:*

  • macOS version: macOS 13.5.1 (22G90) (ARM64)
  • Cog version: Version 2817 (2817-g8d2425b06)

Additional context
Add any other context about the issue here.

@kode54
Copy link
Collaborator

kode54 commented Oct 9, 2023

This should be fixed now.

@nyanpasu64
Copy link
Author

Tried the latest Cog Version 2846 (2846-gf52de150). If I hit Command-Right 2 times in a row it works (although the play icon jumps around a bit in the list). If I press it 4-5 or more times quickly, it enters a state where and all songs fail to play and advance to the next song every few seconds (either immediately, or playback stops and this error occurs when I resume playback). One time Cog beachballed instead.

(I'm mostly using mpd on a spare laptop hooked up to room speakers, with game audio files pre-converted to .flac, to play music now. But I can still test this bug to see if it's fixed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants