Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opus format files no longer show tags when using CoreAudioDecoder #403

Open
faxx1080 opened this issue Oct 8, 2024 · 1 comment
Open
Assignees

Comments

@faxx1080
Copy link

faxx1080 commented Oct 8, 2024

Describe
I noticed file tags (Artist, album, etc) don't show up with opus files anymore.
I tracked this down to PluginController.m:audioDecoderForSource and metadataForURL.

This code restores old behavior:

          if(  ([[_decoders objectAtIndex:i] isEqualToString:@"CoreAudioDecoder"])
             && ( [ext isEqual:@"opus"] || [ext isEqual:@"OPUS"] )   ) {
            DLog(@"PATCH: Removing CoreAudioDecoder for opus - this is for playing not metadata");
            [_decoders removeObjectAtIndex:i];

To Reproduce (delete if not applicable)
Steps to reproduce the behavior:

  1. Add an opus file
  2. Tags don't show up.

Expected behavior
Tags should show up.

Version information:*

  • macOS version: 15.0.1
  • Cog version: Version 2859 (2859-g8498bba88)

Additional context
I believe a recent macOS update (14.6) may have added CoreAudioDecoder for opus files, causing this to happen.

@kode54
Copy link
Collaborator

kode54 commented Oct 8, 2024

Feel free to adjust this to a lower priority instead:

https://github.com/losnoco/Cog/blob/main/Plugins/CoreAudio/CoreAudioDecoder.m#L378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants