Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Disambiguate doc around ECC detection on the data interface #2200

Open
vogelpi opened this issue Aug 8, 2024 · 2 comments
Open

[doc] Disambiguate doc around ECC detection on the data interface #2200

vogelpi opened this issue Aug 8, 2024 · 2 comments
Assignees
Labels
Component:Doc Documentation issue

Comments

@vogelpi
Copy link
Contributor

vogelpi commented Aug 8, 2024

The Ibex documentation currently specifies:
https://ibex-core.readthedocs.io/en/latest/03_reference/security.html#bus-integrity-checking

When the SecureIbex parameter is set, incoming data will be checked against the supplied checkbits.

https://ibex-core.readthedocs.io/en/latest/03_reference/load_store_unit.html#bus-integrity-checking

The core can optionally generate and verify check bits sent alongside the data for memory accesses.

The former statement suggests that all received data is checked (also when no load/store is going on) which is what is really happening. While the latter suggests that only response data of actual load/store instructions is checked. We should correct the second statement to disambiguate the documentation here.

This got flagged by Yin Mengyuan and @KatCe .

@vogelpi vogelpi added Type:Bug Bugs Component:Doc Documentation issue and removed Type:Bug Bugs labels Aug 8, 2024
@vogelpi vogelpi self-assigned this Aug 8, 2024
@KatCe
Copy link
Contributor

KatCe commented Aug 9, 2024

The unspecified behavior was found by @Mengyuan410

@vogelpi
Copy link
Contributor Author

vogelpi commented Aug 9, 2024

Thanks for your feedback and for sharing Mengyuan's GitHub handle @KatCe .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Doc Documentation issue
Projects
None yet
Development

No branches or pull requests

2 participants