Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mac] Build problems after changing perTab to perWindow #37

Open
ltilve opened this issue Jul 27, 2015 · 2 comments
Open

[Mac] Build problems after changing perTab to perWindow #37

ltilve opened this issue Jul 27, 2015 · 2 comments

Comments

@ltilve
Copy link
Owner

ltilve commented Jul 27, 2015

There are build issues after the last changes applied at 5b4e587 to port at the cocoa part the perWindow approach.

@ltilve
Copy link
Owner Author

ltilve commented Jul 27, 2015

../../chrome/browser/ui/cocoa/browser_window_cocoa.mm:830:18: error: instance method '-updateSidebarForTabContents:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
[controller_ updateSidebarForTabContents:tab_contents];
^~~~~~~~~~~~~~~~~~~~~~~~~~~

It seems that we need some change as:
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
@@ -315,7 +315,7 @@ void BrowserWindowCocoa::BookmarkBarStateChanged(
void BrowserWindowCocoa::UpdateDevTools() {
[controller_ updateDevToolsForContents:
browser_->tab_strip_model()->GetActiveWebContents()];

  • UpdateSidebarForContents(browser_->tab_strip_model()->GetActiveWebContents());
  • UpdateSidebarForContents(browser_->tab_strip_model()->GetActiveWebContents(), nullptr);
    }

or at some other points using [controller_ updateSidebarForContents:tab_contents];

@ryumiel
Copy link
Collaborator

ryumiel commented Jul 28, 2015

Build was fixed at 05463409cb79b88133c7ee6d74bd833fc55abffc
However, we need to change sidebar_controller not to rely on TabContentsController

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants