PrimitiveTypeConstraint issue, where it blocks its own constraint ConstraintSolvingIncompleteError

[karl-police]

TEST_CASE_FIXTURE(ACBuiltinsFixture, "test1")
{
    ScopedFastFlag sff[]{
        {FFlag::LuauSolverV2, true},
        //{FFlag::DebugLuauLogSolver, true},
        //{FFlag::DebugLuauLogBindings, true},
        //{FFlag::DebugLuauLogSolverToJson, true}
    };

    CheckResult check1 = check(R"(
local v1: string?

local stringButItIsHere = "Windows"

v1 = if true then stringButItIsHere
elseif false then "Something"
else "Other"
)");

    //LUAU_REQUIRE_NO_ERRORS(check1);

    auto test1 = requireType("v1");
    //auto test2 = toString(check1.errors[1]);
}

_{https://discord.com/channels/385151591524597761/1283231116387680388}

This triggers Type '"Windows"' could not be converted into '("Windows" <: 'a <: string)'

and many more

v1 = if true then stringButItIsHere
elseif false then "Something"
else "Other"

The issue is that this assignment is not resolving into string, hence why that typemismatch error happens.

This is the Solver JSON for it: https://paste.ivr.fi/amidomibop.json

 

Other

I tried this change.

This worked until it triggered an error on a different Unit Test.

https://luau-lang.github.io/dcr-timetraveler/

Which was the Unit Test string_singleton_in_if_statement2

JSON Files for DCR Time Traveler:

• Broken version from attempted change: https://paste.ivr.fi/raw/hihusokaba

• Without the changes: https://paste.ivr.fi/raw/abamihisos