Merge pull request #833 from TerriaJS/issue/728

Issue/728 Fixed an issue that search may not be added to recent search list in some cases

Author: AlexGilleran

CHANGES.md

@@ -48,6 +48,8 @@
 *   Fixed an issue that users may see an error after page 4
 *   Fixed an issue that prevents users from searching current search text by clicking search button or pressing enter key
 *   keep distance between search box and the first story on mobile view
+*   Fixed an issue search may not be added to recent search list in some cases
+*   Make small position adjustment to the recent search icon
 *   Added spacing between download & new tab button on dataset page
 *   Added spacing on byline of dataset page
 *   Moved homepage config from S3 to local

magda-web-client/src/Components/Search/SearchSuggestionBox.js

@@ -9,7 +9,6 @@ import { Small, Medium } from "../../UI/Responsive";
 import "./SearchSuggestionBox.css";
 import recentSearchIcon from "../../assets/updated.svg";
 import closeIcon from "../../assets/mobile-menu-close.svg";
-import isEqual from "lodash.isequal";
 
 type searchDataType = {
     name: ?string,
@@ -166,8 +165,6 @@ class SearchSuggestionBox extends Component {
         const searchData = this.createSearchDataFromProps(newProps);
         if (!searchData) return;
         if (!searchData.data.q || !searchData.data.q.trim()) return;
-        const currentSearchData = this.createSearchDataFromProps(prevProps);
-        if (isEqual(currentSearchData, searchData)) return;
         const recentSearches = this.insertItemIntoLocalData(
             "recentSearches",
             searchData
@@ -187,7 +184,7 @@ class SearchSuggestionBox extends Component {
             isMouseOver: false,
             selectedItemIdx: null
         });
-        this.searchInputRef.blur();
+        if (this.searchInputRef) this.searchInputRef.blur();
     }
 
     onSearchItemClick(e, item: searchDataType) {

magda-web-client/src/Components/Search/SearchSuggestionBox.scss

@@ -54,7 +54,7 @@
                     margin-left: 3px;
                 }
                 @media (max-width: $medium - 1) {
-                    margin-top: 6px;
+                    margin-top: 5.5px;
                 }
                 float: left;
                 width: 25px;